Closed Bug 1792502 Opened 1 year ago Closed 1 year ago

Crash tests should collapse selection to end of text node rather than end of parent parent element to emulate the behavior before bug 1789967

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- unaffected
firefox107 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1792502 - Correct the emulation in crashtests for bug 1789967 r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review

I misunderstood the traditional behavior before bug 1789967, that is, HTMLEditor collapsed Selection to end of the deepest last child container element or text node of the <body>, rather than to end of only the deepest last child container element. This misunderstanding caused the backout of the first landing, but I didn't realize this mistake.

Set release status flags based on info from the regressing bug 1789967

status-firefox105: --- → unaffected
status-firefox106: --- → unaffected
status-firefox107: --- → affected
status-firefox-esr102: --- → unaffected

I misunderstood the traditional behavior before bug 1789967, that is,
HTMLEditor collapsed Selection to end of the deepest last child container
element or text node of the <body>, rather than to end of only the
deepest last child container element. This misunderstanding caused the backout
of the first landing, but I didn't realize this mistake.

Therefore, this patch makes the crashtests which are touched in bug 1789967 and
the collapsed point is at a text node (or failed to consider the collapsed
point) collapse Selection to end of the deepest last text node of their
<body> elements.

Type: defect → task
Type: task → defect
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/561d75b5153b
Correct the emulation in crashtests for bug 1789967 r=m_kato

https://hg.mozilla.org/mozilla-central/rev/561d75b5153b

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox107: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.