Closed Bug 1792525 Opened 2 months ago Closed 2 months ago

Exception: TypeError: userId is undefined (in function updateHdrIcons in enigmailMsgHdrViewOverlay.js)

Categories

(MailNews Core :: Security: OpenPGP, defect)

Thunderbird 102
defect

Tracking

(thunderbird_esr102 affected, thunderbird106 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
thunderbird_esr102 --- affected
thunderbird106 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file)

When opening various encrypted/signed OpenPGP messages, I notice the following exception, probably happening when processing one of the MIME parts:

Uncaught (in promise) TypeError: userId is undefined
updateHdrIcons chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:211
updateSecurityStatus chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:1080
displayStatus chrome://openpgp/content/modules/mimeDecrypt.jsm:674
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:598
sync chrome://openpgp/content/modules/cryptoAPI/interface.js:56
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:546
enigmailMsgHdrViewOverlay.js:211:7

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/cbf6da840358
Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Comment on attachment 9296315 [details]
Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: exception in error console
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low, involves creating a string that's only shown potentially in an error message

Attachment #9296315 - Flags: approval-comm-beta?

Actually, there's slightly more risk. By no longer running into the exception, in the affected scenario some additional code will be executed (that was previously aborted by of the exception).

That previously skipped code is regularly executed in good scenarios, though, and should be fine to execute in that scenario, too.

Comment on attachment 9296315 [details]
Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

[Triage Comment]
Approved for beta

Attachment #9296315 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.