1792525 - Exception: TypeError: userId is undefined (in function updateHdrIcons in enigmailMsgHdrViewOverlay.js)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

When opening various encrypted/signed OpenPGP messages, I notice the following exception, probably happening when processing one of the MIME parts:

Uncaught (in promise) TypeError: userId is undefined
updateHdrIcons chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:211
updateSecurityStatus chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:1080
displayStatus chrome://openpgp/content/modules/mimeDecrypt.jsm:674
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:598
sync chrome://openpgp/content/modules/cryptoAPI/interface.js:56
onStopRequest chrome://openpgp/content/modules/mimeDecrypt.jsm:546
enigmailMsgHdrViewOverlay.js:211:7

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cbf6da840358
Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 9296315 [details]
Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: exception in error console
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low, involves creating a string that's only shown potentially in an error message

Comment 4

[Kai Engert (:KaiE:)]

Actually, there's slightly more risk. By no longer running into the exception, in the affected scenario some additional code will be executed (that was previously aborted by of the exception).

That previously skipped code is regularly executed in good scenarios, though, and should be fine to execute in that scenario, too.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9296315 [details]
Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 106.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d26b974fe081

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9296315 [details]
Bug 1792525 - Prevent exception "userId is undefined" for OpenPGP messages. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.6.0:
https://hg.mozilla.org/releases/comm-esr102/rev/3328a1b7a7a6