1792550 - Signing in to FxA with the primary password locked doesn't work correctly and leaves the user disconected.

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering]

Found in

• Firefox 106.0b4

Affected versions

• Firefox 106.0b4
• Latest Nightly 107.0a1

Tested platforms

• Affected platforms: macOS 11.6, Windows 10, Ubuntu 18.04

Steps to reproduce

1. Set up a primary password
2. Restart Firefox
3. Login to FxA
4. Wait a bit and dismiss the primary password panel
5. Go to Firefox View
6. Click the Try Again button

Expected result

• The primary password panel appears again.

Actual result

• Nothing happens.

Regression range

• This behaviour is from the time the Try Again button was implemented in Bug 1787619 so it is not a regression.

Additional notes

• Here is the output from the console

Sync encountered an error - see about:sync-log for the log file. policies.js:975
1664277278438	FirefoxView.TabsSetup	DEBUG	tryToClearError: triggering new tab sync
1664277278438	FirefoxView.TabsSetup	DEBUG	Handling UIState update
1664277278439	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277278439	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277278439	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277279060	FirefoxView.TabsSetup	DEBUG	Handling weave:service:sync:finish
1664277279060	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277279060	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277279061	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277279062	FirefoxView.TabsSetup	DEBUG	Handling UIState update
1664277279062	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277279062	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277279062	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277279372	FirefoxView.TabsSetup	DEBUG	tryToClearError: triggering new tab sync
1664277279373	FirefoxView.TabsSetup	DEBUG	Handling UIState update
1664277279373	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277279373	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277279373	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277280175	FirefoxView.TabsSetup	DEBUG	Handling weave:service:sync:finish
1664277280176	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277280176	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277280176	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277280177	FirefoxView.TabsSetup	DEBUG	Handling UIState update
1664277280177	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277280177	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277280177	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error
1664277282560	FirefoxView.TabsSetup	DEBUG	tryToClearError: triggering new tab sync
1664277282561	FirefoxView.TabsSetup	DEBUG	Handling UIState update
1664277282561	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, conditions not met to exit state: : error-state
1664277282561	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, will notify update?:: true
1664277282561	FirefoxView.TabsSetup	DEBUG	maybeUpdateUI, in error state:: sync-error

Comment 1

[Bogdan Maris, Desktop Test Engineering]

Attachment: error-sync-1664280851912.txt

And here is the log from about:sync-log

Comment 2

[:Gijs (he/him)]

Mark/Sammy, any idea what's happening here?

Comment 3

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #0)

5. Go to Firefox View
6. Click the Try Again button

Expected result

• The primary password panel appears again.

Actual result

• Nothing happens.

Over in bug 1792553 you have:

• Go to Firefox View and click Try Again
• Enter the correct primary password

Which seems to contradict this? (ie, this says no re-prompt, that reports a bug in what happens after a re-prompt)

switching needinfo to Sam who landed support for try-again re-prompting last week.

Comment 4

[Bogdan Maris, Desktop Test Engineering]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #3)

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #0)

5. Go to Firefox View
6. Click the Try Again button

Expected result

• The primary password panel appears again.

Actual result

• Nothing happens.

Over in bug 1792553 you have:

• Go to Firefox View and click Try Again
• Enter the correct primary password

Which seems to contradict this? (ie, this says no re-prompt, that reports a bug in what happens after a re-prompt)

switching needinfo to Sam who landed support for try-again re-prompting last week.

The difference between the steps from bug 1792553 and the steps from this bug is that, in bug 1792553 I do a restart after logging into Firefox Accounts which makes the prompt appear.

Part of steps from bug 1792553:

3. Login to FxA
4. Dismiss the primary password modal (if prompted)
5. Restart Firefox

Comment 5

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #4)

The difference between the steps from bug 1792553 and the steps from this bug is that, in bug 1792553 I do a restart after logging into Firefox Accounts which makes the prompt appear.

Part of steps from bug 1792553:

3. Login to FxA
4. Dismiss the primary password modal (if prompted)
5. Restart Firefox

But it has:
6. Dismiss the primary password modal (if prompted)
7. Notice that the user is still logged in to FxA
8. Go to Firefox View and click Try Again

So it still seems identical to me.

Regardless, I can't reproduce either of these bugs on a current Nightly - try again consistently re-prompts for a primary password, and things work correctly once it is entered, and works "as expected" when it is entered incorrectly (ie, continues to reprompt until canceled or entered correctly, and at no point can I see Firefox tell me FxA is disconnected.

Are you still able to repro on a new Nightly?

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Indeed, I can still reproduce this issue and the one from bug 1792553 using latest Nightly 107.0a1 (buildID: 20221003212025) from today. I used both a dummy account (guerrillamail) or a yahoomail account. Please let me know if I can help debug this if you still can't reproduce them.

Comment 7

[Bogdan Maris, Desktop Test Engineering]

I also made a video on how I am able to reproduce this, the file is too large to upload it directly here so I uploaded it to Mozilla Gdrive: https://drive.google.com/file/d/1hcJ-v-J9Wom039SThKFxVdUbEgi0sMhO/view?usp=sharing

Comment 8

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Ah, sorry for the confusion, I missed the critical part where you are logging in to fxa with the primary password locked. I'm surprised I can't find an existing bug for this, but it has existed forever. The problem is that we can't store the FxA credentials in this state, so Sync doesn't think it is logged in, and upon restarting we find no credentials in the login manager and force signing back in - this process will repeat until the user unlocks.

I think bug 1792553 should be closed as a dupe of this. A simple solution is probably to just cancel the signin process if the user declines to unlock.

Comment 9

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: Bug 1792550 - ensure the primary password is unlocked before signing in to sync. r?Mardak,Gijs,sfoster

Comment 10

[:Gijs (he/him)]

Mark, is this ready to land?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77055a1b1fc3
ensure the primary password is unlocked before signing in to sync. r=Mardak,sfoster

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/77055a1b1fc3

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:markh, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

:markh, is this bug important enough to require an uplift?

Gijs, I'm inclined to think we should not uplift this as it's not a trivial patch and the bug has existed for years - however, you might take a different view through a Firefox View lens - WDYT?

Comment 16

[:Gijs (he/him)]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #15)

:markh, is this bug important enough to require an uplift?

Gijs, I'm inclined to think we should not uplift this as it's not a trivial patch and the bug has existed for years - however, you might take a different view through a Firefox View lens - WDYT?

106 rc has been built already and this isn't important enough to respin RCs.

Comment 17

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 107.0b3, After setting a Primary password the user can no longer sign in to FXA without typing the Primary password first.