1792567 - deCOM nsIMacUtils

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

In her review of my patch in bug 1792355, Nika noted that the methods of nsIMacUtils are never used, and we never construct an instance of nsMacUtilsImpl.

I have a patch that deletes the unused methods, removes the XPIDL interface, then moves all of the private fields and methods into the CPP file and turns nsMacUtilsImpl into a namespace.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1792567, part 1 - deCOM and remove unused methods in nsMacUtilsImpl.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1792567, part 2 - Turn nsMacUtilsImpl into a namespace.

All of the private methods and fields get moved into the .cpp file,
and reordered where needed.

Comment 3

[Andrew McCreight [:mccr8]]

The second patch is a bit of code churn, so I'm not sure if it is entirely worthwhile.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63e7210c153a
part 1 - deCOM and remove unused methods in nsMacUtilsImpl. r=spohl
https://hg.mozilla.org/integration/autoland/rev/83c15124953e
part 2 - Turn nsMacUtilsImpl into a namespace. r=spohl

Comment 5

[Cristian Tuns]

Backed out for causing build bustages on GMPParent.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/gmp/GMPParent.cpp:212:26: error: no member named 'GetArchitecturesForBundle' in namespace 'nsMacUtilsImpl'

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to Cristian Tuns from comment #5)

[...]

• Failure line: /builds/worker/checkouts/gecko/dom/media/gmp/GMPParent.cpp:212:26: error: no member named 'GetArchitecturesForBundle' in namespace 'nsMacUtilsImpl'

I actually double-checked if we were still using GetArchitecturesForBundle anywhere before r+-ing the patch, but somehow still missed this case.

Comment 7

[Andrew McCreight [:mccr8]]

Ah, and I was building locally on x86 so I guess it didn't catch it. I thought I looked for the uses, too, but I guess I missed it.

Comment 8

[Andrew McCreight [:mccr8]]

I should have checked more carefully, but it looks like that chunk of code isn't getting indexed by SearchFox. I'll file a bug about it.

Comment 9

[Andrew McCreight [:mccr8]]

The Arch64 build looks green with my new version of the patch.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f425664b9ece
part 1 - deCOM and remove unused methods in nsMacUtilsImpl. r=spohl
https://hg.mozilla.org/integration/autoland/rev/29a767270609
part 2 - Turn nsMacUtilsImpl into a namespace. r=spohl

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f425664b9ece
https://hg.mozilla.org/mozilla-central/rev/29a767270609