Rename the ACCESSIBILITY define to MOZ_ACCESSIBILITY
Categories
(Core :: Disability Access APIs, task)
Tracking
()
People
(Reporter: fabrice, Unassigned)
Details
While working on a gecko port using an Android 13 platform, we are facing build breakage due to the redefinition of the ACCESSBILITY define. It's difficult to fix on the Android side since if comes from auto-generated code.
Would you be ok with a patch switching Gecko to use MOZ_ACCESSIBILITY instead? If so I can provide the patch.
Thanks!
|
||
Comment 1•3 years ago
|
||
Is the non-Mozilla ACCESSIBILITY define part of Android itself or some library we're using?
Either way, I think this is probably fine, but tagging Eitan for additional signoff.
|
|
||
Comment 2•3 years ago
|
||
As a side note, I really wish we didn't have this define at all - people shouldn't be building without a11y anyway and it has caused us problems in the past - but changing that probably requires consultation with more people.
|
Reporter | |
Comment 3•3 years ago
|
||
It's part of Android itself (the code is generated from aidl files).
|
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 4•3 years ago
|
||
Any opinion on what to do here? Would you accept a patch?
Description
•