1792650 - Ship Object.groupBy and Map.groupBy

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Tom S]

This is now shipping in Chrome. Is our implementation up to date and shippable?

Comment 2

[André Bargull [:anba]]

(In reply to Tom S [:evilpie] from comment #1)

This is now shipping in Chrome. Is our implementation up to date and shippable?

Yes, I think so. Bug 1841518 updated it to match the current spec text.

Comment 3

[Tom S]

Attachment: Bug 1792650 - Enable Object.groupBy and Map.groupBy by default. r?#spidermonkey-reviewers

Comment 4

[Tom S]

Attachment: Bug 1792650 - Update tests. r?#spidermonkey-reviewers

Depends on D188229

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb89bc7df1c9
Enable Object.groupBy and Map.groupBy by default. r=spidermonkey-reviewers,mgaudet
https://hg.mozilla.org/integration/autoland/rev/be325dcc5de7
Update tests. r=spidermonkey-reviewers,mgaudet

Comment 6

[Atila Butkovits]

Backed out for causing failures at test_xrayToJS.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bf46943cf6e944c8f192ffab271d3f1cbad46357

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=QsUV8fpZRzWPO8Tq_k1CXA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ecc245e6c1644825a53e0e4085347043a793a40f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=429187120&repo=autoland&lineNumber=7025

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a72901f9845
Enable Object.groupBy and Map.groupBy by default. r=spidermonkey-reviewers,mgaudet
https://hg.mozilla.org/integration/autoland/rev/9451f52d9cd4
Update tests. r=spidermonkey-reviewers,mgaudet

Comment 8

[ljharb]

Awesome! When's the next release scheduled, and for which version?

Comment 9

[Iain Ireland [:iain]]

This is landing in Firefox 119. It looks like it should hit release on October 24. See the calendar here.

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5a72901f9845
https://hg.mozilla.org/mozilla-central/rev/9451f52d9cd4

Comment 11

[Donal Meehan [:dmeehan]]

:evilpie is this something you would like to nominate for a release note? https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 12

[Tom S]

Release Note Request (optional, but appreciated)
[Why is this notable]: New JavaScript feature
[Affects Firefox for Android]: yes
[Suggested wording]: Easier grouping of items in an array (and iterables) by using the methods Object.groupBy or Map.groupBy.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/groupBy https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/groupBy

Comment 13

[Hamish Willee]

FF119 docs work for this can be tracked in https://github.com/mdn/content/issues/29303 (Mostly just compatibility data and removing experimental tagging in MDN docs).

Comment 14

[Dianna Smith [:diannaS]]

Added to 119 beta release notes (https://www.mozilla.org/en-US/firefox/119.0beta/releasenotes/) as well as the Draft release notes for 119