1792652 - May fail to move selected content to absolutely positioned `<div>`

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is a regression of bug 1762115, but I'm not sure how did I take this mistake...
https://searchfox.org/mozilla-central/diff/974fe7d420a13b04461ee9b0a571e0bf08847bc4/editor/libeditor/HTMLEditSubActionHandler.cpp#10130

          nsAtom* ULOrOLOrDLTagName =
              atContent.GetContainer()->NodeInfo()->NameAtom();
          if (targetDivElement) {
            // XXX Do we need to split the container? Since we'll append new
            //     element at end of the <div> element.
            const SplitNodeResult splitNodeResult =
                MaybeSplitAncestorsForInsertWithTransaction(
                    MOZ_KnownLive(*ULOrOLOrDLTagName), atContent);
-           if (splitNodeResult.isErr()) {
+           if (splitNodeResult.isOk()) {
              NS_WARNING(
                  "HTMLEditor::MaybeSplitAncestorsForInsertWithTransaction() "
                  "failed");
              return splitNodeResult.unwrapErr();
            }

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1762115

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, the path is used only by SeaMonkey and looks like that there is no plan to ship new stable branch with ESR102.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that it's enough to be fixed in bug 1792641 which touches all SplitNodeResult users (I found this bug when I was working on it).

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Fixed by the landing of bug 1792641.