1792656 - Toolbox can be fully collapsed to the side

Status: VERIFIED FIXED

(DevTools :: General, defect, P1)

Description

[Julian Descottes [:jdescottes]]

This seems to be a recent regression. The toolbox can be fully collapsed to the bottom (or to the side if docked to the right/left).

This puts the tools in an unrecoverable state, users have to go into about:config to restore a valid size for the toolbox.

This seems to be Nightly only.

Comment 1

[Julian Descottes [:jdescottes]]

https://searchfox.org/mozilla-central/rev/d45dd05bf412e7468b3770a52519e9d546d6325c/devtools/client/themes/devtools-browser.css#13

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Bug 1792277 fixes it, afaict.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks Emilio, it seems that Bug 1792277 fixes part of the issue (when the toolbox is docked to bottom), but I can still fully collapse the toolbox to the side.

Comment 4

[Julian Descottes [:jdescottes]]

For info the minwidth seems to actually be enforced in JS here: https://searchfox.org/mozilla-central/rev/d45dd05bf412e7468b3770a52519e9d546d6325c/devtools/client/framework/toolbox-host-manager.js#146

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789168

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792656 - Use style attribute to set min-width on toolbox host frame. r=jdescottes

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb476eea488a
Use style attribute to set min-width on toolbox host frame. r=jdescottes

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bb476eea488a

Comment 9

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Nightly 107.0a1 (2022-09-27) using Win10.
Verified - Fixed in Beta 107.0b3 and the latest Nightly 108.0a1 (2022-10-21) on Windows 10, macOS 12 and Ubuntu 20 for all 3 dock options (bottom, right side and left side).