Closed Bug 1792667 Opened 2 years ago Closed 2 years ago

The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Iteration:
108.1 - Oct 17 - Oct 28
Tracking Flags:
Tracking Status
firefox106 --- wontfix
firefox107 --- wontfix
firefox108 --- verified

People

(Reporter: avarro, Assigned: nsauermann)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Screen Recording 2022-09-28 at 11.39.17.mov
2.66 MB, video/quicktime
Details
Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed
48 bytes, text/x-phabricator-request
Details | Review

[Affected versions]:

  • Firefox Beta 106.0b5 - Build ID: 20220927185813
  • Firefox Nightly 107.0a1 - Build ID: 20220927213841

[Affected Platforms]:

  • Windows 10 x64
  • macOS 12.3.1
  • Linux Mint 20.2 x64

[Prerequisites]:

  • Have a new Firefox profile opened.

[Steps to reproduce]:

  1. Click the “Firefox View” pinned tab from the left part of the “Tab Strip”.
  2. Click the “See how it works” button from the “Welcome” spotlight.
  3. Observe the first callout message anchored to the “Tab Pickup” section.
  4. Click the arrow pointed upwards from the “Tab Pickup” area to collapse the section.

[Expected result]:

  • The “Tab Pickup” section is collapsed and the “Tab Pickup” callout message still points to that section.

[Actual result]:

  • The “Tab Pickup” section is collapsed and the “Tab Pickup” callout message points to the “Recently Closed” section from the Firefox View page.

[Notes]:

  • This issue is also reproducible for the “Tab pickup” callout message from the Continuous Onboarding tour.
  • Attached is a screen recording of the issue:
Blocks: 1787189
status-firefox106: --- → affected
OS: Unspecified → All
Hardware: Unspecified → Desktop
Assignee: nobody → nsauermann
Iteration: --- → 107.1 - Sept 19 - Sept 30
Iteration: 107.1 - Sept 19 - Sept 30 → 107.2 - Oct 3 - Oct 14
Priority: -- → P1
Attachment #9297319 - Attachment description: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed → WIP: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed
Attachment #9297319 - Attachment description: WIP: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed → Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed
Attachment #9297319 - Attachment description: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed → WIP: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed
Attachment #9297319 - Attachment description: WIP: Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed → Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed
Iteration: 107.2 - Oct 3 - Oct 14 → 108.1 - Oct 17 - Oct 28
Pushed by nsauermann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acec464308f9
The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed r=mviar,emcminn

https://hg.mozilla.org/mozilla-central/rev/acec464308f9

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

I have verified this issue using the latest Firefox Nightly 108.0a1 (Build ID: 20221019083142) on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm the following:

  • The “Tab Pickup” callout message points to the same section when the “Tab Pickup” section is collapsed/expanded.
Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified

The patch landed in nightly and beta is affected.
:nsauermann, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nsauermann)
status-firefox107: affected → wontfix
Flags: needinfo?(nsauermann)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: