Closed Bug 1792673 Opened 2 months ago Closed 2 months ago

Private Search urlbar result pref typo

Categories

(Firefox :: Search, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- verified
firefox106 --- verified
firefox107 --- verified

People

(Reporter: aflorinescu, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1790673 should set browser.search.separatePrivateDefault.urlbarResult.enabled, but looking in about:config it sets browser.search.separatePrivateDefaultUrlbarResultEnabled

Assignee: nobody → standard8

This was actually from bug 1790790.

Blocks: 1790790
No longer blocks: 1790673
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cda677e5aeef
Correctly set the separate private default urlbar result preference from experiments. r=daleharvey

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Beta/Release Uplift Approval Request

  • User impact if declined: Minor correction to bug 1790790 to set the correct preference.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: QA already have steps.
  • List of other uplifts needed: Bug 1790790
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small correction to existing code, includes additional tests.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9296447 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Approved for 106.0b6.

Attachment #9296447 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Beta/Release Uplift Approval Request

  • User impact if declined: Minor correction to bug 1790790 to set the correct preference.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: QA already have steps.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small correction to existing code, includes additional tests.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9296447 - Flags: approval-mozilla-release?
QA Whiteboard: [qa-triaged]

Issue is verified fixed in Fx 107.0a1 and Fx 106.0b6 on windows 10 and ubuntu 22. The pref is now correctly displayed as browser.search.separatePrivateDefault.urlbarResult.enabled.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Approved for 105.0.2.

Attachment #9296447 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.

QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.