1792673 - Private Search urlbar result pref typo

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Bug 1790673 should set browser.search.separatePrivateDefault.urlbarResult.enabled, but looking in about:config it sets browser.search.separatePrivateDefaultUrlbarResultEnabled

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Comment 2

[Mark Banner (:standard8)]

This was actually from bug 1790790.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cda677e5aeef
Correctly set the separate private default urlbar result preference from experiments. r=daleharvey

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: Minor correction to bug 1790790 to set the correct preference.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA already have steps.
• List of other uplifts needed: Bug 1790790
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small correction to existing code, includes additional tests.
• String changes made/needed: None
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Approved for 106.0b6.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cda677e5aeef

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/518a82954897

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: Minor correction to bug 1790790 to set the correct preference.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA already have steps.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small correction to existing code, includes additional tests.
• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

Issue is verified fixed in Fx 107.0a1 and Fx 106.0b6 on windows 10 and ubuntu 22. The pref is now correctly displayed as browser.search.separatePrivateDefault.urlbarResult.enabled.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296447 [details]
Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r?daleharvey

Approved for 105.0.2.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3a9b5c9560ae

Comment 12

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.