Closed Bug 1792691 Opened 2 months ago Closed 2 months ago

openpgp error dialogs no longer work

Categories

(MailNews Core :: Security: OpenPGP, defect, P1)

Thunderbird 107

Tracking

(thunderbird_esr102 unaffected, thunderbird106 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird106 --- fixed

People

(Reporter: KaiE, Assigned: mkmelin)

References

Details

(Keywords: regression)

Attachments

(1 file)

Using Daily 107, in the following scenario, our code attempts to show an error dialog, but fails and runs into an exception - and an empty dialog is shown.

Create an OpenPGP secret key, configure an account to use it.
Then use OpenPGP key manager to delete that secret key (the account will still have it configured).
Then compose a new email and enable openpgp signing, then send.
This will trigger the attempt to show an error message, that the key cannot be found.

Uncaught TypeError: can't access property "setAttribute", dlg.getButton(...) is undefined
onLoad chrome://openpgp/content/ui/enigmailMsgBox.js:15
onload chrome://openpgp/content/ui/enigmailMsgBox.xhtml:1
msgBox chrome://openpgp/content/modules/dialog.jsm:131
alert chrome://openpgp/content/modules/dialog.jsm:64
prepareSendMsg chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js:1832
sync chrome://openpgp/content/modules/cryptoAPI/interface.js:56
sendMessageListener chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js:2330
CompleteGenericSendMessage chrome://messenger/content/messengercompose/MsgComposeCommands.js:5903
GenericSendMessage chrome://messenger/content/messengercompose/MsgComposeCommands.js:5865
enigmailMsgBox.js:15:7

Version: unspecified → Thunderbird 107

Ah, I missed a part in bug 1787393.
Of course the whole enigmailMsgBox.js should really be moved to standard functionality as well :/

Assignee: nobody → mkmelin+mozilla
See Also: → 1787393
Status: NEW → ASSIGNED
Target Milestone: --- → 107 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2008a74f9d8f
remove obsolete "help" dialog button reference. r=kaie

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

Comment on attachment 9296574 [details]
Bug 1792691 - remove obsolete "help" dialog button reference. r=kaie

[Approval Request Comment]
Regression caused by (bug #): bug 1784882
User impact if declined: Some non-functional error alerts
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Attachment #9296574 - Flags: approval-comm-beta?

Comment on attachment 9296574 [details]
Bug 1792691 - remove obsolete "help" dialog button reference. r=kaie

[Triage Comment]
approved for beta

Attachment #9296574 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.