1792695 - [Existing users] The “[object Object]” tooltip text is displayed when hovering the default icon theme from the existing users’ Onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: TooltipText_DefaultIcon_ExistingUsers.png

[Affected versions]:

• Firefox Nightly 107.0a1 (Build ID: 20220927213841)

[Affected Platforms]:

• macOS 12.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of the Firefox Nightly build installed and opened.
• Have the “devtools.chrome.enabled” pref set to true.
• Have the “Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog();” syntax copied to the Clipboard.

[Steps to reproduce]:

1. Focus the Browser Console (Ctrl + Shift + J) and paste the syntax from prerequisites.
2. Press the “Enter” key.
3. Click the “Skip this step” button until the “Colorways” modal is shown.
4. Hover the default icon theme from the “Colorways” section.
5. Observe the tooltip text.

[Expected result]:

• The “Current Nightly colors” text is displayed.

[Actual result]:

• The “[object Object]” text is displayed.

[Regression Window]:

• The issue is not reproducible with older Nightly 107.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
  Last good revision: 53c77ef3d63c3fc2a1adad40c62c34d4b6b582dc
  First bad revision: 41536b72cac02fe05685a4c08ef93220c051e110
  Pushlog: link

From this pushlog it seems that Bug 1791861 may have introduced this behavior.

[Notes]:

• This issue is not reproducible on the screen of the “about:welcome” page.
• Attached is a screenshot of the issue.

Comment 1

[Simona Rosu [:srosu], Ecosystem QA]

• @Emily, could you please take a look over this issue?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1791861

Comment 3

[Emily McMinn :emcminn]

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #1)

• @Emily, could you please take a look over this issue?

Hey, Simona! Looks like I missed updating the JSON for existing onboarding when I updated the string ID. I'll put together a quick patch.

Comment 4

[Emily McMinn :emcminn]

Attachment: Bug 1792695 - Update Fluent ID for default colorway tooltip on exisiting user onboarding

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cee58f83544
Update Fluent ID for default colorway tooltip on exisiting user onboarding r=negin

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1cee58f83544

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 107.0a1 (Build ID: 20221002212226) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The “Current Nightly colors” tooltip text is displayed when hovering the default icon theme from the Colorways modal of the existing users’ Onboarding.