1792709 - quick filter stops working, can't find any way to get it back

Status: RESOLVED DUPLICATE of bug 1745007

(Thunderbird :: Search, defect)

Description

[Jonathan Kamens]

When the Expression Search add-on upgraded to 3.5.1 today my quick filter simply stopped working. I tried disabling the add-on and restarting, and that didn't help. I tried removing the add-on completely (not just disabling it) and restarting, and that didn't help either.

I see these errors in the error console on startup:

filterDef is undefined QuickFilterManager.jsm:542
createSearchTerms resource:///modules/QuickFilterManager.jsm:542
createSearchTerms resource:///modules/QuickFilterManager.jsm:166
updateSearch chrome://messenger/content/quickFilterBar.js:656
onTabRestored chrome://messenger/content/quickFilterBar.js:478
restoreTab chrome://messenger/content/mailTabs.js:262
restoreTab chrome://messenger/content/tabmail.js:1487
restoreTabs chrome://messenger/content/tabmail.js:1508
atStartupRestoreTabs chrome://messenger/content/msgMail3PaneWindow.js:1350
InterpretGeneratorResume self-hosted:1422
AsyncFunctionNext self-hosted:632
aFilterValue is null QuickFilterManager.jsm:1235
reflectInDOM resource:///modules/QuickFilterManager.jsm:1235
reflectFiltererState chrome://messenger/content/quickFilterBar.js:288
onTabRestored chrome://messenger/content/quickFilterBar.js:480
restoreTab chrome://messenger/content/mailTabs.js:262
restoreTab chrome://messenger/content/tabmail.js:1487
restoreTabs chrome://messenger/content/tabmail.js:1508
atStartupRestoreTabs chrome://messenger/content/msgMail3PaneWindow.js:1350
InterpretGeneratorResume self-hosted:1422
AsyncFunctionNext self-hosted:632

I see this additional error when I attempt to do a search:

Uncaught TypeError: aState is null
onCommand resource:///modules/QuickFilterManager.jsm:1177
handler chrome://messenger/content/quickFilterBar.js:241
_fireCommand chrome://global/content/elements/search-textbox.js:230
_enterSearch chrome://global/content/elements/search-textbox.js:248
on_keypress chrome://global/content/elements/search-textbox.js:211
handleEvent chrome://global/content/customElements.js:466

It seems like perhaps there is some broken state stored somewhere, but I can't figure out where it's stored or how to get rid of it.

This Shouldn't Happen.

Comment 1

[Jonathan Kamens]

Figured out that I could make quick filter start working again by removing session.json from my profile.

Still, the errors quoted above should be handled better so that users don't have to do that if something corrupted in the quick filter metadata.

FWIW here's what was in search.json before I removed it:

{
  "rev": 0,
  "windows": [
    {
      "type": "3pane",
      "tabs": {
        "rev": 0,
        "selectedIndex": 0,
        "tabs": [
          {
            "mode": "folder",
            "state": {
              "folderURI": "imap://[elided]@[elided]/INBOX",
              "folderPaneVisible": true,
              "messagePaneVisible": true,
              "firstTab": true
            },
            "ext": {
              "quickFilter": {
                "filterValues": {
                  "expression-search-filter": {
                    "text": "compliance"
                  }
                },
                "visible": true
              }
            }
          }
        ]
      }
    }
  ]
}

Comment 2

[Magnus Melin [:mkmelin]]

Bug 1745007 related/dupe.
But if we can figure out a way to handle it, that would be great.