1792730 - Contents of dialog are truncated( or shrink) when resize `View Certificates...` dialog etc

Status: VERIFIED FIXED

(Toolkit :: Preferences, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps To reproduce:

1. Open about:preferences#privacy
2. Click View Certificates...
3. Drag the resizer widget at the bottom right corner

Actual results:
Contents of dialog are truncated.
See attached screenshot

Expect results:
Render properly

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cfb00673e44e09f9eddfff6d814b99062cdbcf09&tochange=0bd09bf30151a8adf162df98669cd1b6d015b17d

Comment 1

[Alice0775 White]

Dialogs with the resizer are also affected.
Such as Connection Settings Manage Exceptions... Clear Data... Manage Data... and dialogs of Permissions section etc.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1790307, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792730 - Allow resizable dialog frames to stretch. r=Gijs

UL honored the flex over explicit width.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792730 - Keep dialogs stretching over their preferred width after bug 1665476. r=Gijs

width gets honored properly now. What these want is really a min-width.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f82d191c31a2
Allow resizable dialog frames to stretch. r=Gijs,preferences-reviewers

Comment 6

[Marian-Vasile Laza]

Backed out changeset f82d191c31a2 (Bug 1792730) for causing bc failures on browser_subdialogs.js.
Backout link
Push with failures <--> bc14
Failure Log

Comment 7

[Alice0775 White]

FYI. autoland build 82d191c31a2 still has the following problems
The contents does not increase the width. It stays original width.

Steps To reproduce:

1. Open about:preferences#privacy
2. Click Manage Exceptions... of the top, Settings... of Permissions
3. Drag the Resizer widget in the lower right corner to increase the width of the dialog.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Yes, that's what the other patch fixes.

Comment 9

[erosman]

Attachment: history.png

History window from Build ID 20220929014928
Ubuntu 22.04 Wayland

Comment 10

[Emilio Cobos Álvarez (:emilio)]

That's similar but different (bug 1792809).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4cffd7fd12d
Allow resizable dialog frames to stretch. r=Gijs,preferences-reviewers

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e4cffd7fd12d

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473e72a1c3a3
Keep dialogs stretching over their preferred width after bug 1665476. r=Gijs,preferences-reviewers,eemeli

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/473e72a1c3a3

Comment 15

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue with Firefox 107.0a1.
Verified as fixed with Firefox 107.0b3 and Nightly 108.0a1 on Windows 10x64, Ubuntu 18.4 and macOS 10.12.6.