1792748 - Sidebar width is no longer restored after restart

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR

1. Start from a clean profile (or at least a profile with only one window)

• You may need to enable "Open previous windows and tabs", unsure...

2. Open a sidebar, such as bookmarks (View -> Sidebars -> Bookmarks)
3. Change the sidebar width (to some non-default value you'll recognise) by dragging the splitter
4. Restart Firefox

ER

The custom sidebar width should be restored after Firefox restart when the window opens.

AR

The default sidebar width is used instead.

Notes

The correct custom width is being loaded and set as a width attribute on sidebar-box, but this is perhaps being ignored with the modern flexbox mode...?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Emilio, perhaps you have some idea what's going on since you've worked on the switch to modern flexbox here...?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789168

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792748 - Persist sidebar style attribute rather than width attribute. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ec263b6ba8c
Persist sidebar style attribute rather than width attribute. r=Gijs

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ec263b6ba8c

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I have verified that the core fix for new sidebar widths is working, but the migration code has a small error. I've attached a fix over in bug 1793366.

Comment 7

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue in Nightly 107.0a1 (2022-09-28) using Windows 10.
Verified - Fixed in Beta 107.0b3 and the latest Nightly 108.0a1 (2022-10-21) on Windows 10, macOS 12 and Ubuntu 20.