Open Bug 1792760 Opened 2 months ago Updated 1 month ago

Zoom control keyboard shortcuts for reader mode do not fully match normal zoom control keyboard shortcuts

Categories

(Toolkit :: Reader Mode, defect, P3)

Firefox 105
Desktop
All
defect

Tracking

()

People

(Reporter: robbie_dobbie1, Unassigned, NeedInfo)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

  1. go to Reader Mode compatible website. News sites are typically best. (bbc / the register etc etc )
    1.view in browser mode and reader mode.
    2.set browser to a zoom level <> (or !=) 100%
    3.view page in browser then reader mode.
    4.close and re-open browser, power-cycle the host device, kill processes, clear caches etc etc.
  2. Repeat steps 0-5
    note zoom levels between the two modes.
    5.1 - Change Zoom in Reader Mode via keyboard, mouse wheel and menu.

Actual results:

  1. "Reader Mode" zoom level doesn't correlate with "Browser Mode"
    Setting Browser to 90% zoom and then opening reader mode, always opens reader mode on it's last zoom setting, and is not inferred nor inherited from the browser zoom setting.
  2. "Reader Mode".
    Changes to zoom only work with the Following:
    -) "+" and "-" buttons on the dedicatated Zoom Toolbar Tool * (available via Menu pancake -> More tools -> Customise toolbar).
    -) The Menubar -> View -> Zoom -> "Zoom In" and "Zoom Out" works correctly. *
    -)"Ctrl + Mousewheel" scroll also works as expected. *
    -)"Ctrl + +" and "Ctrl + -" *

BUT... Ctrl + 0 (native to some of us that use keyboard shortcuts as a convenience) does NOT Reset Zoom Level in Reader Mode.

The reason for the asterisk is:
3) Those are compounded when in Reader Mode. The current Zoom Level, is not displayed in the Zoom control toolbar tool or anywhere else on screen in reader mode.

Expected results:

  1. "Reader Mode" zoom level doesn't correlate with "Browser Mode"
    . switching between either mode should maintain a consistent Zoom Level

  2. Fix 'Keyboard Shortcuts' to be consistent between "Reader Mode" and "Browser Mode".

  3. Fix control labelling to reflect current Zoom Level in reader mode.

Screen shots are not neccessary as full description to recreate the problem is given and the problem is universal; in that regardless of add-ons , locale, website, the bug is persistent.
NOTE: that's not a refusal to assist more! i can provide info or screenshots if required.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Reader Mode' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Reader Mode
Product: Firefox → Toolkit

(In reply to Rob N from comment #0)

  1. "Reader Mode" zoom level doesn't correlate with "Browser Mode"
    . switching between either mode should maintain a consistent Zoom Level

Fixing this is a non-goal. Our expectation is that you/we (users) configure reader mode as we like it - you can adjust line lengths, font type, font size, theming, etc. - and that there would then be no reason to want those settings to change those based on which website you were viewing.

Zoom in reader mode really only changes the font size - the line lengths are specified in font-size agnostic units and as a result the perception is that the page "zooms" but that is not really what happens under the hood. Having it "inherit" from the page would be confusing for users and lead to unexpected outcomes.

  1. Fix 'Keyboard Shortcuts' to be consistent between "Reader Mode" and "Browser Mode".

If I'm understanding this correctly this really means "make cmd/ctrl-0 reset the zoom like it does outside reader mode", right? I agree that this should work, I'm just trying to understand if there's some other way the keyboard shortcuts are not consistent/working.

  1. Fix control labelling to reflect current Zoom Level in reader mode.

There was existing discussion in bug 1595064 around this. PDFs have the same issue (separate zoom levels that aren't reflected in the main browser's zoom indicators), but fixing this is not trivial. Similar to PDFs, reader mode zoom is not really identical to "normal" zoom as I've outlined above. As a workaround, you can inspect the zoom level in the reader mode toolbar by checking the number between the "+" and "-" in the type controls popup (if useful, while pressing ctrl-+ and ctrl--). Any further discussion of this particular issue should happen in bug 1595064, not here - we try to keep bugs focused on 1 issue at a time because otherwise the discussion becomes hard to follow, as well as making it tricky to decide when something is "fixed" if fixing 1 of the many issues outlined there is much easier/harder than the others.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(robbie_dobbie1)
OS: Unspecified → All
Hardware: Unspecified → Desktop
See Also: → 1595064
Summary: 3-in-1 userland bugs. Browser Mode; Reader Mode; Zoom control KB shortcut. → Zoom control keyboard shortcuts for reader mode do not fully match normal zoom control keyboard shortcuts
Severity: -- → S4
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.