Closed Bug 1792802 Opened 2 years ago Closed 2 years ago

Column picker does not work in Page info media tab and about:preferences#privacy View certification dialog

Categories

(Core :: XUL, defect)

Firefox 107
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- unaffected
firefox107 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files)

Steps To Reproduce:

  1. Open Page Info ( Ctrl+I )
  2. Click Media tab
  3. Click column picker at the right side of table header
  4. Select a column name (e.g. Size)
  5. optionally, try to repeat step 3 and 4

Actual Results:
Nothing added header.
Clicking on the column picker does not show the dropdown except the first time.

Expected Results:
The column should be added/removed.
The second and subsequent clicks on the column picker should also show/hide a dropdown.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=51423d631a9acaaabaa931809c54b083a63ca533&tochange=d43a9bd44619d8b122caa97a64cabf5c185b8623

Note:
If select a columun name in Step 4 with keyboard, the selected column will show/hide as expected.

Component: Page Info Window → XUL
Product: Firefox → Core
Summary: Column picker does not work in Page info media tab → Column picker does not work in Page info media tab and about:preferences#privacy View certification dialog

about:preferences#privacy > View certification...,
the Certificate Manager dialog is also affected.

:emilio, since you are the author of the regressor, bug 1790920, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Assignee: nobody → emilio

This element had a really weird dependency on the order of the command
events from the menuitems and the button which broke in bug 1790920.

Instead of keeping this element as a XULButtonElement, have a separate
button and popup. That's simpler and less prone to breakage, and allows
to get rid of special cases in Gecko.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9249f760526
Fix tree column picker. r=aminomancer

Backed out for causing mochitest failures on test_struct_tree.xhtml

Backout link

Push with failures

Failure log

Flags: needinfo?(emilio)

After the previous change, the treecolpicker element only wraps a button
and a menu, which are siblings rather than parent/child. I think that's
probably fine but it changes the shape of the a11y tree.

This patch updates the relevant tests, but let me know if you'd rather
keep the behavior. I could do that by either keeping the treecolpicker
entry listed in XULMap (I think), or via other means.

Suggestions welcome if you think this is not the right fix.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df75f29cded6
Fix tree column picker. r=aminomancer
https://hg.mozilla.org/integration/autoland/rev/c14f7934269f
Fix accessible tests after previous change. r=Jamie
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Flags: qe-verify+

Verified as fixed in our latest Beta 107.0b3.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.