1792819 - The default search engine changed prompt is displayed even when the previous engine is still available

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Mark Banner (:standard8)]

The prompt we have for displaying information about a user's default engine being removed can also be displayed if the application default is changed - even if the original engine is still available.

This leads to a confusing message. For now, we'll add a check to see if the engine still exists or not before displaying.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1792819 - Only prompt about the default search engine change when the previous engine is actually removed. r?daleharvey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98316d30841
Only prompt about the default search engine change when the previous engine is actually removed. r=daleharvey

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 9296616 [details]
Bug 1792819 - Only prompt about the default search engine change when the previous engine is actually removed. r?daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: This avoids a confusing infobar being show in a few situations.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA are testing this as part of work.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes to when the infobar is displayed, well tested code.
• String changes made/needed: None
• Is Android affected?: No

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296616 [details]
Bug 1792819 - Only prompt about the default search engine change when the previous engine is actually removed. r?daleharvey

Approved for 106.0b7.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d44901ef53a

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b98316d30841

Comment 7

[Adrian Florinescu [:aflorinescu]]

Verified on Windows 10, Ubuntu 22.04 and Mac 11 using Beta 106.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9296616 [details]
Bug 1792819 - Only prompt about the default search engine change when the previous engine is actually removed. r?daleharvey

Approved for 105.0.2.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/60bc76fb1d42

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed with 105.0.2 on Ubuntu 22.04, Mac 11 and Windows 10.

Comment 11

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 107.0b2 and 108.0a1 (2022-10-19) on Ubuntu 22.04, Mac 11 and Windows 10.