179296 - [BMP] support images with negative height (stored top-to-bottom)

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

the bmp code should support top-to-bottom BMP images.

They are indicated by a negative width.

eog and gqview support this, probably many other programs as well.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: testcase - should look upside-down

this image was taken from jason summer's test suite (referenced from bug 18502,
at least) and was slightly modified to have a negative height.

It should look upside-down on mozilla.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[ArronM (:paper)]

Comment on attachment 105862 [details] [diff] [review]
patch

Just as a side note (not needed for this bug), if I read my BMP specs correctly
BMPINFOHEADER.width should also be a PRInt32 (and we should abort on negative
width)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

very well... now width is signed as well

Comment 5

[tor]

Comment on attachment 105980 [details] [diff] [review]
patch v2

Small nit: I would have made both the ?: statements test the same condition.

sr=tor

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed