Closed Bug 1792991 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36065 - Revert "Bluetooth: Remove setUpPreconnectedDevice()"

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 36065 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36065
Details from upstream follow.

Giovanni Ortuno Urquidi <ortuno@chromium.org> wrote:

Revert "Bluetooth: Remove setUpPreconnectedDevice()"

This reverts commit 260bbfb38ca0faa8e823c8977cd5e17569b805ca.

Reason for revert: Suspected of breaking external/wpt/bluetooth/service/getCharacteristics/characteristics-found.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/104693/test-results

Looks like it's only on windows:

https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fbluetooth%2Fservice%2FgetCharacteristics%2Fcharacteristics-found-with-uuid.https.window.html

Original change's description:

Bluetooth: Remove setUpPreconnectedDevice()

Update the existing setUpHealthThermometerDevice() to use the new
setUpPreconnectedFakeDevice() and cleanup unused code of
setUpPreconnectedDevice().

Bug: 1070816
Change-Id: Ia033109a60a312f86b005d213a2317b94fbfd9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912723
Commit-Queue: Jack Hsieh \<chengweih@chromium.org>
Reviewed-by: Ovidio Ruiz-Henríquez \<odejesush@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1050727}

Bug: 1070816
Change-Id: I9fd33b92c250d2d986767322e8cafb3ca1c8ebde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916061
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Giovanni Ortuno Urquidi \<ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1051072}

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 214 tests and 1 subtests ## Status Summary ### Firefox `ERROR`: 214 ### Chrome `OK` : 148 `FAIL` : 148 `ERROR`: 66 ### Safari `ERROR`: 214 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=9d380d0e660d9ed865aec9793aa73e0de006f4ce&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=9d380d0e660d9ed865aec9793aa73e0de006f4ce&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a2234e082c9 [wpt PR 36065] - Revert "Bluetooth: Remove setUpPreconnectedDevice()", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: