1793010 - [wpt-sync] Sync PR 36075 - Line-height should be forced to 'normal' for canvas setFont

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36075 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36075
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Line-height should be forced to 'normal' for canvas setFont

No need to apply line-height as it should end up as 'normal' per spec
anyway[1].

Set the parent style to point to the canvas element to resolve lh units
correctly.

[1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-font

Bug: 937104
Change-Id: Ib141ca9b5664a896fe86abf2bb25d9d1368e7ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914695
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1051659}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b48698c223769da044d258f62c451715b2dc2f44

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 1

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/text-styles/parent-style-relative-units.html [wpt.fyi]
  • Font-size based on canvas element line-height: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02a97e5661fc
[wpt PR 36075] - Line-height should be forced to 'normal' for canvas setFont, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ee4c0077bd5b
[wpt PR 36075] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/02a97e5661fc
https://hg.mozilla.org/mozilla-central/rev/ee4c0077bd5b