1793041 - [wpt-sync] Sync PR 36120 - Reland "Bluetooth: Remove setUpPreconnectedDevice()"

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36120 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36120
Details from upstream follow.

Jack Hsieh <[e-mail]> wrote:

Reland "Bluetooth: Remove setUpPreconnectedDevice()"

This reverts commit 46e09f76c21b8b8ab938bdc420806c6615b78734.

Reason for revert: Fix the test failure on WebKit Win10 and reland.

Original change's description:

Revert "Bluetooth: Remove setUpPreconnectedDevice()"

This reverts commit 260bbfb38ca0faa8e823c8977cd5e17569b805ca.

Reason for revert: Suspected of breaking external/wpt/bluetooth/service/getCharacteristics/characteristics-found.https.window.html

https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/104693/test-results

Looks like it's only on windows:

https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fbluetooth%2Fservice%2FgetCharacteristics%2Fcharacteristics-found-with-uuid.https.window.html

Original change's description:

Bluetooth: Remove setUpPreconnectedDevice()

Update the existing setUpHealthThermometerDevice() to use the new
setUpPreconnectedFakeDevice() and cleanup unused code of
setUpPreconnectedDevice().

Bug: 1070816
Change-Id: Ia033109a60a312f86b005d213a2317b94fbfd9c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3912723
Commit-Queue: Jack Hsieh \<[e-mail]>
Reviewed-by: Ovidio Ruiz-Henríquez \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1050727}

Bug: 1070816
Change-Id: I9fd33b92c250d2d986767322e8cafb3ca1c8ebde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916061
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Giovanni Ortuno Urquidi \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1051072}

Bug: 1070816
Change-Id: I8843319588eb559c4917d5f1d527939abd66ba8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3919733
Reviewed-by: Ovidio Ruiz-Henríquez \<[e-mail]>
Commit-Queue: Jack Hsieh \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1052509}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=993a4085c23614cd0a38fb2f53d84ea570a1ff70

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 214 tests and 1 subtests

## Status Summary

### Firefox
`ERROR`: 214

### Chrome
`OK`   : 214
`PASS` : 2
`FAIL` : 213

### Safari
`ERROR`: 214

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=993a4085c23614cd0a38fb2f53d84ea570a1ff70)
[GitHub PR Head](https://wpt.fyi/results/?sha=b18dcd532226245951e5fd6f6b120431d8ae36f0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=b18dcd532226245951e5fd6f6b120431d8ae36f0&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c206d5102937
[wpt PR 36120] - Reland "Bluetooth: Remove setUpPreconnectedDevice()", a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c206d5102937