Closed Bug 1793064 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36146 - [last-baseline] Propagate last baslines from flexbox.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36146 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36146
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[last-baseline] Propagate last baslines from flexbox.

This modifies flex's baseline accumulator to support three(!) potential
baselines for the first & last baseline.

Firstly we prefer the major/minor baseline for the first/last baseline
of the first/last line.

Then we prefer the minor/major baseline for the first/last baseline of
the first/last line.

Finally fallback baseline is the first/last item in the first/last line.

Bug: 885175
Change-Id: I8113c48e3f6861895f89585f39fd9268e5d70f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914072
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: David Grogan \<dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053037}

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4b20ef502cdd [wpt PR 36146] - [last-baseline] Propagate last baslines from flexbox., a=testonly https://hg.mozilla.org/integration/autoland/rev/8dfd73d56b22 [wpt PR 36146] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/4b20ef502cdd
https://hg.mozilla.org/mozilla-central/rev/8dfd73d56b22

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.