Closed Bug 1793100 Opened 2 years ago Closed 2 years ago

Port bug 1792730: Set min-width instead of width

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr102 unaffected)

RESOLVED FIXED
107 Branch
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Target Milestone: --- → 107 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/95a3b31c98f1
Port bug 1792730: Set min-width instead of width. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

As explained multiple times before, you cannot change existing strings without new IDs. And yes, that includes removing attributes, because now all localizations will have errors.
https://firefox-source-docs.mozilla.org/l10n/fluent/review.html#changes-to-existing-messages

@magnus
Please back this out as soon as possible.

I'm going to manually remove it from cross-channel for now (automation will add it back in 12 hours), but if I didn't catch this by pure luck, this would have broken release if you ever uplift new localizations.

Flags: needinfo?(mkmelin+mozilla)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

(In reply to Francesco Lodolo [:flod] from comment #4)
Thanks for noticing! Will get the patch to update those l10n keys landed.

Flags: needinfo?(mkmelin+mozilla)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/82359195a6bf
Use new l10n IDs for the changed dialogs. r=#thunderbird-reviewers

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cb51158f0619
Make dialogs and window keep stretching after bug 1665476. r=aleca

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: