1793116 - Privacy pane does not handle small window width well in DE langpack

Status: RESOLVED DUPLICATE of bug 1795049

(Firefox :: Settings UI, defect, P1)

Description

[Tim Giles [:tgiles] | OOO Jun 4-10]

Attachment: image.png

When using the German langpack, the about:preferences#privacy section does not handle small window sizes well due to hboxes/labels that do not wrap at smaller screen sizes. I'm not sure if we can totally prevent the horizontal scrollbar in this case (or for other languages), but we should be able to reduce the width range in which the scrollbar appears. (There's probably a better way to word the title, feel free to change)

I think with this bug, we can close out Bug 1773212 since the original concern of that bug was addressed and fixed.

Comment 1

[Tim Giles [:tgiles] | OOO Jun 4-10]

I can fix most of the issues on this pane, but the custom level of tracking protection poses a unique problem with that menulist dropdown element. It appears that this menulist element causes the vertical scrollbar to disappear at certain widths, first between 830px and 867px and then again at <699px. This will most likely need to be addressed in a different bug since it will involve a layout change that will be inconsistent with the other instances of menulists in about:preferences.

Comment 2

[Tim Giles [:tgiles] | OOO Jun 4-10]

Attachment: menulist-on-its-own-row-at-830px-wide

Just for reference (and on top of my current change for this patch) I can prevent the vertical scrollbar from disappearing into the horizontal space if I move the menulist to its own row in the custom protection area. At least, I can prevent the scrollbar from becoming unusable at the 830px to 867px wide range. I can't prevent this issue at <622px though, the menulist options are just too long, at least when the options are in German.

Comment 3

[Tim Giles [:tgiles] | OOO Jun 4-10]

Attachment: Bug 1793116 - Fix some non-wrapping elements in the privacy pane. r=#preferences-reviewers

Fix breach alerts box not wrapping in DE langpack.
Fix Windows SSO box not wrapping in DE langpack.
Fix addon recommendation box not wrapping in DE langpack.
Fix studies box not wrapping in DE langpack.
Fix learn more text getting cut off for saved addresses and credit card
buttons.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Tim, do the patches in bug 1795049 fix this as well? Might be a bit more generic fix.

Comment 5

[Tim Giles [:tgiles] | OOO Jun 4-10]

So it looks like the vertical scrollbar disappearing in the horizontal space got fixed by something else. I'll try mozregression so we can pin that down. I'm not able to reproduce that particular issue on the latest central commit (https://hg.mozilla.org/mozilla-central/rev/4563dd583110be33b4767284f04e1ea83f1a78bc).

I'm still getting horizontal scrollbars when window.innerWidth == 992 like originally reported on that same latest central commit. I'm not seeing horizontal scrollbars at width == 992 given :emilio's patch, it appears between width 828 - 976 now, then reappears at <807px. It also appears at <808px on :emilio's patch versus latest central where it appears at <995px. Because of this, I believe we can dupe this to Bug 1795049. Still curious about what fixed the menulist eating the vertical scrollbar issue, I'll report back about that.

Comment 6

[Tim Giles [:tgiles] | OOO Jun 4-10]

(In reply to Tim Giles [:tgiles] from comment #5)

So it looks like the vertical scrollbar disappearing in the horizontal space got fixed by something else. I'll try mozregression so we can pin that down. I'm not able to reproduce that particular issue on the latest central commit (https://hg.mozilla.org/mozilla-central/rev/4563dd583110be33b4767284f04e1ea83f1a78bc).

Got a fix log of https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=30bdee9799a07b8770719aa868416174ff0c54f5&tochange=81578db6bf8939678d490b69f0daf4b675027e3a and it looks like Bug 1793730 might be a likely candidate for fixing this disappearing scrollbar issue, but I'm just giving it a quick skim as it isn't too vital that I find a perfect candidate for the vertical scrollbar disappearing issue.

Anyway, given that bug 1795049 makes the wrapping situation a bit better for more locales (and is a more generic fix than my patch and also way less code) I'm going to dupe this bug to that one.