1793186 - SessionStorage: BrowserState with selected tab id for tab that doesn't exist

Status: NEW

(Firefox for Android :: General, defect)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/android-components/issues/8417.

We switched from saving a SessionManager.Snapshot to a BrowserState in #7867 / 9e60a62119e4d0cb352642940faaec9da00fe1e1.

We now see the "selected tab" check fail. As a workaround I'll write a patch that clears the selected tab id in the state we are writing to disk, in that situation.

Nevertheless we should investigate how we end up in such a situation. Our reducer definitely doesn't do any checks when setting the selected tab id. But maybe this is intentional for "out of order" actions? Let's find out.

https://sentry.prod.mozaws.net/operations/firefox-beta/issues/9527493

        if (state.normalTabs.isEmpty()) {
            clear()
            return true
        }

        if (state.selectedTabId != null) {
            requireNotNull(state.selectedTab) {
                "Selected session must exist"
            }
        }

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.