[wpt-sync] Sync PR 36117 - MSE-in-Workers: Relaunch with flag guards and handle visibility restricted
Categories
(Core :: Audio/Video: Playback, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 36117 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/36117
Details from upstream follow.
Matt Wolenetz <wolenetz@chromium.org> wrote:
MSE-in-Workers: Relaunch with flag guards and handle visibility restricted
This undoes the previous launch revert commit 887a8c4e3d5203b0528e7c911b24be3aa67d2b4e, and includes multiple fixes.
Switches the two RuntimeEnabled features that enable MSE-in-Workers
from experimental to stable status:
MediaSourceInWorkers: Basic support, still using legacy object
URLs for attachment
MediaSourceInWorkersUsingHandle: Upgraded to match updated MSE spec, final PR linked below.Updates the stable webexposed expectations for both the Main/Window
context and the DedicatedWorker context.MSE spec PRs with handle usage refinements:
- https://github.com/w3c/media-source/pull/306
- this relaunch also includes implementation of spec fix from
https://github.com/w3c/media-source/pull/317Intent-to-ship=https://groups.google.com/a/chromium.org/g/blink-dev/c/FRY3F1v6Two
Versus the original launch, this relaunch:
- adds base::Feature (aka flag-guards) for each of the two
RuntimeEnabledFeatures, above (with same feature name strings).
This is to comply with mandatory flag-guarding PSA process update,
and is meant to mitigate possible binary respins in the event this
feature pair yet again needs to be disabled.- updates the MediaSource.handle attribute getter to fix the
regression responsible for the previous revert, complying with
MSE spec that was fixed to prevent that regression (see PR #317
linked above):
- Removes NotSupportedError exception throwing logic from the
handle attribute getter.- Restricts visibility of the handle attribute to only dedicated
worker contexts (removes visibility of it from the main/Window
context versus previous launch attempt), along with corresponding
webexposed stable web_tests expectations matching this change.- Updates mediasource-worker-handle.html web_test to no longer
expect NotSupportedError exception, nor even ability to access the
handle attribute of a MediaSource object on the main/window
context.BUG=878133
Change-Id: Id34a07254b9b98e79c495429f8ed79555b0c4580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910706
Commit-Queue: Will Cassella \<cassew@chromium.org>
Reviewed-by: Mike Taylor \<miketaylr@chromium.org>
Reviewed-by: Will Cassella \<cassew@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053854}
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 10 subtests
Status Summary
Firefox
OK : 1
PASS: 2
FAIL: 2
Chrome
OK : 1
PASS: 8
FAIL: 1
Safari
OK : 1
PASS: 2
FAIL: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /media-source/dedicated-worker/mediasource-worker-handle.html [wpt.fyi]
- Test main context receipt of postMessage'd MediaSourceHandle from DedicatedWorker MediaSource:
FAIL(Chrome:PASS, Safari:FAIL) - Test main-thread has MediaSourceHandle defined:
FAIL(Chrome:PASS, Safari:FAIL)
- Test main context receipt of postMessage'd MediaSourceHandle from DedicatedWorker MediaSource:
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/063784b4525e
https://hg.mozilla.org/mozilla-central/rev/83591da72b0c
Description
•