Closed Bug 1793469 Opened 3 years ago Closed 3 years ago

"Say hello to Firefox View" modal is not localized

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox108 --- verified

People

(Reporter: tgiles, Unassigned)

Details

Attachments

(1 file)

Attached image image.png

STR:
I'm not sure if there's a pref to control the "Say hello" modal, but you'll need an instance of Firefox (or maybe just a new profile) where you haven't navigated to Firefox View before.

  1. Download a non-English localized build
  1. Change web content language in about:preferences#general to a non-English language
  2. Restart browser to ensure Firefox has changed all of the localized elements
  3. Navigate to Firefox View

Expected:

  • The "Say hello to FIrefox View" modal is localized

Actual:

  • The "Say hello to Firefox View" modal is in English

Venetia -- I think this prompt is coming form the Messages side, correct?

Flags: needinfo?(vtay)

Yes - I will investigate. I will also edit bug

Flags: needinfo?(vtay)
Component: Firefox View → Messaging System

@tgiles What build/ locale were you on?

Priority: -- → P1
Flags: needinfo?(tgiles)

I set my locale to German in this particular instance. Haven't tested with other locales/languages. I tested this locally, I haven't tried with a Nightly localized build but I'm assuming the issue will reproduce in that case too.

Flags: needinfo?(tgiles)

thank you!

based on https://transvision.flod.org/string/?entity=browser/browser/newtab/asrouter.ftl:firefoxview-spotlight-promo-title&repo=gecko_strings, we can confirmed that DE has not been localized yet. Other locales/languages have been translated -- zn-cn, ru confirmed.

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tspurway)

de has been localized. We can close this bug.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

I have verified this issue using the latest Firefox Nightly 108.0a1 DE (Build ID: 20221023100414) on Windows 10x64, macOS 12.6 and Linux Mint 20.2x64 and I can confirm the following:

  • The "Say Hello to Firefox View" spotlight is correctly localized on DE locales.
Status: RESOLVED → VERIFIED
Flags: needinfo?(tspurway)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: