Closed Bug 1793487 Opened 2 months ago Closed 2 months ago

Pocket newtab turn off recent save placeholder images for failed loads and regular stories

Categories

(Firefox :: Pocket, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox106 + verified
firefox107 --- verified

People

(Reporter: thecount, Assigned: thecount)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/39dd7976006b
Pocket newtab fixing placeholder images for recent saves r=gvn

Backed out for causing newtab failures.

[task 2022-10-05T17:54:45.259Z] npm WARN deprecated core-js@2.6.11: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
[task 2022-10-05T17:54:45.587Z] 
[task 2022-10-05T17:54:45.587Z] added 766 packages, and audited 767 packages in 18s
[task 2022-10-05T17:54:45.587Z] 
[task 2022-10-05T17:54:45.587Z] 91 packages are looking for funding
[task 2022-10-05T17:54:45.587Z]   run `npm fund` for details
[task 2022-10-05T17:54:45.615Z] 
[task 2022-10-05T17:54:45.615Z] 25 vulnerabilities (11 moderate, 12 high, 2 critical)
[task 2022-10-05T17:54:45.615Z] 
[task 2022-10-05T17:54:45.615Z] To address issues that do not require attention, run:
[task 2022-10-05T17:54:45.615Z]   npm audit fix
[task 2022-10-05T17:54:45.615Z] 
[task 2022-10-05T17:54:45.615Z] To address all issues possible (including breaking changes), run:
[task 2022-10-05T17:54:45.615Z]   npm audit fix --force
[task 2022-10-05T17:54:45.615Z] 
[task 2022-10-05T17:54:45.615Z] Some issues need review, and may require choosing
[task 2022-10-05T17:54:45.615Z] a different dependency.
[task 2022-10-05T17:54:45.615Z] 
[task 2022-10-05T17:54:45.615Z] Run `npm audit` for details.
[task 2022-10-05T17:54:45.641Z] + node bin/try-runner.js
[task 2022-10-05T17:54:45.676Z] TEST START | checkBundles
[task 2022-10-05T17:54:53.535Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2022-10-05T17:54:53.535Z]   npx browserslist@latest --update-db
[task 2022-10-05T17:54:53.535Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2022-10-05T17:54:53.535Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2022-10-05T17:54:53.535Z]   npx browserslist@latest --update-db
[task 2022-10-05T17:54:53.535Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2022-10-05T17:54:53.538Z] TEST-UNEXPECTED-FAIL checkBundles | Activity Stream bundle out of date
[task 2022-10-05T17:54:53.540Z] { checkBundles: false }
[task 2022-10-05T17:54:53.540Z] CODE 1
[taskcluster 2022-10-05 17:54:54.570Z] === Task Finished ===
[taskcluster 2022-10-05 17:54:54.571Z] Unsuccessful task run with exit code: 1 completed in 289.272 seconds
Flags: needinfo?(sdowne)

[Tracking Requested - why for this release]: Upcoming experiment in 106.

I am fixing the backout now.

Flags: needinfo?(sdowne)
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/08c62f29d5a2
Pocket newtab fixing placeholder images for recent saves r=gvn

Comment on attachment 9297045 [details]
Bug 1793487 - Pocket newtab fixing placeholder images for recent saves

Beta/Release Uplift Approval Request

  • User impact if declined: Impact to images displayed to users in a test possibly being unexpected, to only be displayed when expected.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open a newtab.
  1. Turn off your network.
  2. Scroll down the page so more Pocket stories are scrolled into view.
  3. Expected: There should be no thumbnails images loaded for stories scrolled into view while network is down.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's an single added if block for a segment of users that's pretty small.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9297045 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
QA Whiteboard: [qa-triaged]

Comment on attachment 9297045 [details]
Bug 1793487 - Pocket newtab fixing placeholder images for recent saves

Approved for 106.0b9 (last beta before our release candidate) thanks.

Attachment #9297045 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified that there are no more thumbnails images loaded for the last unloaded stories if the internet is cutoff on the newtab page on Firefox 106.0b9 (treeherder build) and 107.0a1 (2022-10-06). Tests were performed on macOS 13, Ubuntu 22.04 and Windows 11.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.