1793505 - Browser toolbox style editor content frame overflows

Status: VERIFIED FIXED

(DevTools :: Style Editor, defect)

Description

[Shane Hughes [:aminomancer]]

If you open a browser toolbox > style editor > pick a really long stylesheet like browser.css, the stylesheet content's scrollbar overflows off the window, so you can't reach all the code.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Style Editor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1792473

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1793505 - Prevent stylesheet media query list from affecting the minimum size of the style editor panel. r=#devtools-reviewers

Intrinsic sizing of scrollers affecting min-sizes of containing boxes is
one of those annoying behaviors of modern flexbox unfortunately, but
it's easy to fix using containment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4156d542aed2
Prevent stylesheet media query list from affecting the minimum size of the style editor panel. r=devtools-reviewers,ochameau

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4156d542aed2

Comment 6

[Julian Descottes [:jdescottes]]

== Change summary for alert #35638 (as of Fri, 07 Oct 2022 17:22:46 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
35%	damp browser-toolbox.styleeditor-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	468.55 -> 632.08
28%	damp browser-toolbox.styleeditor-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	455.81 -> 582.03
27%	damp browser-toolbox.styleeditor-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	439.44 -> 558.77
23%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	512.68 -> 632.26
23%	damp browser-toolbox.styleeditor-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	437.61 -> 536.38
22%	damp browser-toolbox.styleeditor-ready.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	515.70 -> 630.31

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35638

Comment 7

[Julian Descottes [:jdescottes]]

Performance regressions on styleeditor browser toolbox tests.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Can you file a new bug for the perf regressions and ni? me? Happy to take a look.

Comment 9

[Julian Descottes [:jdescottes]]

Sure! Let me just verify the changesets first, because I can't reproduce the regression locally. This specific regression could also be from Bug 1793687.

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 107.0a1 (2022-10-03) on Windows 10x64.
The issue is no longer reproducible with Firefox 107.0b6 on Windows 10x64, macOS 12 and Ubuntu 20.04. The stylesheet content's scrollbar no longer overflows off the window.