Open Bug 1793510 Opened 3 years ago Updated 3 years ago

no-unused-vars is not enabled at the global scope for GeckoView's module files and xpcshell-tests

Categories

(GeckoView :: General, task, P3)

Product:
GeckoView
Component:
General
Platform:
All
Android
Type:
task

Tracking

(Not tracked)

People

(Reporter: standard8, Unassigned)

Details

GeckoView's .eslintrc.js overrides our standard definitions for no-unused-vars, causing it not to be enabled against the global scope for module files nor for xpcshell-tests.

This can lead to imports not being cleaned up (e.g. this review comment), or other unnecessary variables being left unused.

Ideally, we would remove the overrides and let the main rules apply - this would also allow for changes in future without these being "hidden". However, this would mean either removing all the unnecessary warn/debug imports, or excluding them on a line-by-line basis.

Severity: -- → N/A
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.