1793633 - nsEffectiveTLDService should use threadsafe refcounting

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

nsEffectiveTLDService is already used off-main-thread through the ThirdPartyUtil service (hence the existing RwLock), however it is currently not threadsafe refcounted, or refcounted off-main-thread.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1793633 - Make the nsEffectiveTLDService use threadsafe refcounting, r=#necko-reviewers

This type is used off-main-thread through the ThirdPartyUtil service
(hence the existing RwLock), however it is currently neither threadsafe
refcounted, nor refcounted off-main-thread. This change also allows it
to be directly used off-main-thread, rather than through the
ThirdPartyUtil service.

I also added thread-safety annotations to the fields to get better
static checking for the thread-safety of accesses.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c632e12a7f8
Make the nsEffectiveTLDService use threadsafe refcounting, r=necko-reviewers,dragana

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9c632e12a7f8