1793647 - Send requests with new fetch destination

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, defect)

Description

[Benjamin VanderSloot [:bvandersloot]]

After much deliberation, the standard seems to be settling on using a new Sec-Fetch-Dest value, rather than a custom protected header.

Deliberation: https://github.com/fedidcg/FedCM/issues/320

Merge into Fetch: https://github.com/whatwg/fetch/pull/1495

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1793647, part 1 - Create new Sec-Fetch-Dest value for WebIdentity (FedCM), r=#webidl!,freddyb!

This is to keep up with WHATWG Fetch https://github.com/whatwg/fetch/pull/1495 .

I added an element to nsIContentPolicy::nsContentPolicyType as my starting point and
proceeded from there, following the instructions at the end of the enum.

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1793647, part 2 - Use new Sec-Fetch-Dest value for FedCM, r=timhuang!

InternalRequest::OverrideContentPolicyType was literally built for this.
I just had to call it while building requests and start checking for it in all of the relevant tests.
I know, code duplication is bad, but I think it is easier to see what a test is doing without helpers and they aren't hard to update entirely by hand yet.

Depends on D158657

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a74cdaf71bb
part 1 - Create new Sec-Fetch-Dest value for WebIdentity (FedCM), r=freddyb,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/9a6fed87ccdb
part 2 - Use new Sec-Fetch-Dest value for FedCM, r=timhuang

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6a74cdaf71bb
https://hg.mozilla.org/mozilla-central/rev/9a6fed87ccdb