1793694 - Stop exposing `EditorUtils.h` and `HTMLEditUtils.h`

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

They are designed for internal use in the editor module, but EditorBase.h and HTMLEditor.h depends on them, they are exposed for all. Now we can fix the dependence with some small fixes.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 1: Move some static inline methods of `HTMLEditor` to `HTMLEditUtils` r=m_kato!

Depends on D158483

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 2: Move some protected inline method definitions of `HTMLEditor` to non-exposed header r=m_kato!

Depends on D158631

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 3: Move definitions of `JoinNodesDirection` and `SplitNodeDirection` into a new exposed header file r=m_kato!

They are used in public inline methods of HTMLEditor. Therefore, they should
be defined in an exposed header file without other internal use things for the
editor module. Then, we can stop exposing HTMLEditHelpers.h.

Depends on D158632

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 4: Stop exposing `HTMLEditUtils.h` r=m_kato!

It's currently referred from outside only by TextServicesDocument.cpp.
It's not under libeditor but in the editor module. Therefore, let's allow
it to refer the header files under libeditor directly. Then, we can stop
exposing HTMLEditUtils.h.

Depends on D158633

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 5: Move `EditorUtils::MaskString` to `TextEditor` r=m_kato!

It's the only method which is used outside of the editor module. Therefore,
we can stop exposing EditorUtils.h later.

Depends on D158634

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 6: Stop exposting `EditorUtils.h` r=m_kato!

Depends on D158635

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1793694 - part 7: Stop exposting `CSSEditUtils.h` and `ChangeStyleTransaction.h` r=m_kato!

Depends on D158636

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14ad86b372a2
part 1: Move some static inline methods of `HTMLEditor` to `HTMLEditUtils` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/402a1ce83820
part 2: Move some protected inline method definitions of `HTMLEditor` to non-exposed header r=m_kato
https://hg.mozilla.org/integration/autoland/rev/4840feba9c48
part 3: Move definitions of `JoinNodesDirection` and `SplitNodeDirection` into a new exposed header file r=m_kato
https://hg.mozilla.org/integration/autoland/rev/71af69b71841
part 4: Stop exposing `HTMLEditUtils.h` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/534a55ac55a7
part 5: Move `EditorUtils::MaskString` to `TextEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a5c78fe9d7a3
part 6: Stop exposting `EditorUtils.h` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f29238d734d4
part 7: Stop exposting `CSSEditUtils.h` and `ChangeStyleTransaction.h` r=m_kato

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/14ad86b372a2
https://hg.mozilla.org/mozilla-central/rev/402a1ce83820
https://hg.mozilla.org/mozilla-central/rev/4840feba9c48
https://hg.mozilla.org/mozilla-central/rev/71af69b71841
https://hg.mozilla.org/mozilla-central/rev/534a55ac55a7
https://hg.mozilla.org/mozilla-central/rev/a5c78fe9d7a3
https://hg.mozilla.org/mozilla-central/rev/f29238d734d4