Closed Bug 1793726 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 36278 - [anchor-position] Fix scoping on block fragmentation context root

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36278 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36278
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[anchor-position] Fix scoping on block fragmentation context root

This patch fixes anchor scoping[1] when the containing block
of the querying element is a block fragmentation context root.

In that case, due to how multicol handles OOFs[2], all OOFs
are added to their fragmentainers, not to their containing
blocks. This was supported in r1040243 crrev.com/c/3856814,
but since it is propagated outside of the normal propagations,
it should compute the validity in a different way.

This patch adds |AnchorQuerySetOptions| that computes the
validity for OOFs in a block fragmentation context.

[1] https://tabatkins.github.io/specs/css-anchor-position/#determining
[2] https://docs.google.com/document/d/13Pn7SSJjzskg9kQ4jErzlJrj2j4zGBfNBFLEeDVENUU/edit?usp=sharing

Bug: 1309178
Change-Id: I8dc8387234ffa6286e33fb5d61b99d54e75a4e17

Reviewed-on: https://chromium-review.googlesource.com/3934650
WPT-Export-Revision: 1d5eb14bd80a7c3c4ffe63b69bce0cd69c0bae15

PR 36278 applied with additional changes from upstream: 92952f84efc7c5ffd56faa73e251979f8bf5a2b0
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5311ca549bb [wpt PR 36278] - [anchor-position] Fix scoping on block fragmentation context root, a=testonly https://hg.mozilla.org/integration/autoland/rev/a63b89aab2a1 [wpt PR 36278] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a5311ca549bb
https://hg.mozilla.org/mozilla-central/rev/a63b89aab2a1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.