Closed Bug 1793735 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36280 - [bfcache] Do not reset notRestoredReasons upon successful bfcache navigation

Categories

(Core :: DOM: Performance APIs, task, P4)

Product:
Core
Component:
DOM: Performance APIs
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36280 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36280
Details from upstream follow.

Yuzu Saijo <yuzus@chromium.org> wrote:

[bfcache] Do not reset notRestoredReasons upon successful bfcache navigation

This CL makes PerformanceNavigationEntry.notRestoredReasons not reset
after successful bfcache navigation. After this CL, when the page is
successfully restored from bfcache, the reasons from the previous
navigation stay.

Now, the only time we reset the reasons is when we get a new set of
reasons.

This was discussed on the email thread here:
https://groups.google.com/a/chromium.org/g/bfcache-dev/c/fGPWPVTbyJA

Bug:1363438

Change-Id: I5214f56e8424356cad8190c2a0144e4d1c017746

Reviewed-on: https://chromium-review.googlesource.com/3906513
WPT-Export-Revision: fd42350f750703390709d0b295148ed744a9ad9a

Component: web-platform-tests → DOM: Performance
Product: Testing → Core
PR 36280 applied with additional changes from upstream: 88c0d4ec3d12f5389297f08ced7785e2c402cf36, 9420f456c94ec948f7a93d99663d15b9622a4f01, 8a56cdcecb36c38aed6a45654bd6f01b8f1095bf, dd09af7c378e2fd4270c8c2080dfaaed2d5ba6eb
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 20 tests and 1 subtests

Status Summary

Firefox

OK : 5[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 20[GitHub]
PASS : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 16[GitHub]
FAIL : 4
TIMEOUT: 2
ERROR : 13[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 15[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]

Chrome

OK : 20
PASS : 16
FAIL : 4

Safari

OK : 18
PASS : 16
FAIL : 4
ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fa4936bd60f [wpt PR 36280] - [bfcache] Do not reset notRestoredReasons upon successful bfcache navigation, a=testonly https://hg.mozilla.org/integration/autoland/rev/b2c9bcf49f1f [wpt PR 36280] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4fa4936bd60f
https://hg.mozilla.org/mozilla-central/rev/b2c9bcf49f1f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.