Closed Bug 1793747 Opened 2 years ago Closed 1 year ago

Elements with 'content-visibility: hidden' are visible in the accessibility tree

Categories

(Core :: Disability Access APIs, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: jihye, Assigned: jihye, NeedInfo)

References

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36

Steps to reproduce:

  1. Load the test page with content having 'content-visibility: hidden'
  2. Open the "Web Developer Tools"
  3. Select the "Accessibility" Tab
  4. Check if the content having 'content-visibility: hidden' is shown in the accessibility tree

Actual results:

The content having 'content-visibility: hidden' is shown in the accessibility tree

Expected results:

Referring to the CSS Containment spec,
(https://www.w3.org/TR/css-contain-2/#cv-a11y)

The skipped contents of content-visibility: hidden elements must similarly be "skipped" (omitted) in the accessibility tree (similar to how display: none elements are omitted in all views of the document).

Component: Untriaged → Layout
Depends on: 1758490
Product: Firefox → Core
Summary: Elements with 'content-visibility: hidden' is visible in the accessibility tree → Elements with 'content-visibility: hidden' are visible in the accessibility tree

This change fixs that the element specified with 'content-visibility:hidden' doesn't appear in the accessibility tree.
The approach is not to create the node in a11y tree if the element has 'content-visibility:hidden'.

With this patch, all the tests related to the accessibility tests in wpt_internal directory* are passed.

(*): https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/wpt_internal/display-lock/css-content-visibility/accessibility

Assignee: nobody → jihye
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9299532 - Attachment description: WIP: Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree → Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree
Attachment #9299532 - Attachment description: Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree → WIP: Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree
Attachment #9299532 - Attachment description: WIP: Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree → Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree
Component: Layout → Disability Access APIs
Attachment #9299532 - Attachment description: Bug 1793747 - Omit the element having 'content-visibility:hidden' from the accessibility tree → Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jihye, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(jteh)
Flags: needinfo?(jihye)
Flags: needinfo?(jihye)
Attachment #9299532 - Attachment description: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree → WIP: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree
Attachment #9299532 - Attachment description: WIP: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree → Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree
Attachment #9299532 - Attachment description: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree → WIP: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree
Attachment #9299532 - Attachment description: WIP: Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree → Bug 1793747 - Omit the element hidden by 'content-visibility:hidden' from the accessibility tree
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c670332e2cf1
Omit the element hidden by 'content-visibility:hidden' from the accessibility tree r=emilio,Jamie
https://hg.mozilla.org/integration/autoland/rev/0d107468f537
Clean-ups and test fixes on top of the previous patch. r=Jamie
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/cb7498983717
Address comment nits that I forgot to upload.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: