1793769 - Continual mozilla::gfx::DrawTargetWebgl::SharedContext::CreateShaders

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I see this while running https://storage.googleapis.com/tfjs-testing/segmentation-landscape/index.html on macOS.

https://share.firefox.dev/3UXxz6F

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Note: this was with gfx.canvas.accelerated.profile-frames=0

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1793769 - Avoid trying to create DrawTargetWebgl if shader compilation failed. r?aosmond

If we fail to compile DrawTargetWebgl's shaders, we bail out to a normal software canvas.
However, it will still try to create a DrawTargetWebgl every time we need to create a canvas.
To avoid this, remember if shader compilation failed in the process, and don't try to create
an accelerated canvas again in that case.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1793769 - Avoid recreating the main DrawTargetWebgl SharedContext. r?aosmond

For canvas users that rapidly create and destroy canvases, we may end up creating
a new SharedContext (and hence ClientWebGLContext) if there are no more canvases
left between destruction and creation. To work around this, just keep alive the
SharedContext for the main thread (other threads are unfortunately a bit tricky
to support) so that canvas creation remains fast in this instance.

Depends on D158903

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0737cb829b7e
Avoid trying to create DrawTargetWebgl if shader compilation failed. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/6387a6e7bbd5
Avoid recreating the main DrawTargetWebgl SharedContext. r=aosmond

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in @ std::_Hashtable<unsigned int, std::pair<unsigned int const, RefPtr<mozilla::WebGLTextureJS>

Backout link: https://hg.mozilla.org/integration/autoland/rev/0db234071bf67f735564bbd0c2a37edaf84fb909

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a92b6503fe
Avoid trying to create DrawTargetWebgl if shader compilation failed. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/f824c70961a7
Avoid recreating the main DrawTargetWebgl SharedContext. r=aosmond

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing multiple WebGL related failures

Backout link

Push with failures - xpcshell // Failure log 1 - xpcshell // Failure log 2 - xpcshell

Push with failures - Mn // Failure log - Mn

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee98b3301d0
Avoid trying to create DrawTargetWebgl if shader compilation failed. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/5bc65958fa5c
Avoid recreating the main DrawTargetWebgl SharedContext. r=aosmond

Comment 9

[Norisz Fay [:noriszfay]]

Hello, this remote failure appeared on the full push as well a bit towards the end of the running tests, could you take a look at it as well? Thank you! Failure log here.

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9ee98b3301d0
https://hg.mozilla.org/mozilla-central/rev/5bc65958fa5c

Comment 11

[Mayank Bansal]

Adding blocking to bug 1741501 as this bug improves the use of gpu-canvas (bug 1774972)