Closed
Bug 1793776
Opened 2 years ago
Closed 2 years ago
Add pref for opus stereo fmtp parameter
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
107 Branch
Tracking | Status | |
---|---|---|
firefox107 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(2 files)
This is strictly about whether we request stereo from the other end.
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → docfaraday
Assignee | ||
Updated•2 years ago
|
Severity: S3 → S2
Priority: P3 → P2
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Assignee | ||
Comment 3•2 years ago
|
||
Setting this pref to true will result in stereo=0 in the fmtp for opus.
Depends on D158696
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Comment 5•2 years ago
|
||
Try looks fine.
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bde87499ce2 Test-case for pref. r=jib https://hg.mozilla.org/integration/autoland/rev/550d731db269 Add media.peerconnection.sdp.disable_stereo_fmtp r=jib
Comment 7•2 years ago
•
|
||
Backed out for causing gtest failures.
- backout: https://hg.mozilla.org/integration/autoland/rev/234201789b09bd09e0f8fb243e7855a1cf05da9f
- push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KZh0W-YaR6Sw8AOIst6IIA.0&revision=550d731db269e334a33dab7095ef6128a4299a9d&group_state=expanded
- failure log: https://treeherder.mozilla.org/logviewer?job_id=392391884&repo=autoland&lineNumber=29230
[task 2022-10-06T02:39:19.464Z] 02:39:19 INFO - TEST-START | JsepTrackTest.NonDefaultOpusParameters
[task 2022-10-06T02:39:19.465Z] 02:39:19 WARNING - TEST-UNEXPECTED-FAIL | JsepTrackTest.NonDefaultOpusParameters | Expected equality of these values:
[task 2022-10-06T02:39:19.465Z] 02:39:19 INFO - (int)(true)
[task 2022-10-06T02:39:19.465Z] 02:39:19 INFO - Which is: 1
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - (int)audioCodec.mForceMono
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - Which is: 0 @ /builds/worker/checkouts/gecko/media/webrtc/signaling/gtest/jsep_track_unittest.cpp:1459
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - Offer SDP:
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - v=0
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - o= 0 0 IN IP4
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - s=-
[task 2022-10-06T02:39:19.466Z] 02:39:19 INFO - t=0 0
[task 2022-10-06T02:39:19.467Z] 02:39:19 INFO - a=msid-semantic:WMS *
[task 2022-10-06T02:39:19.467Z] 02:39:19 INFO - m=audio 0 UDP/TLS/RTP/SAVPF 109 9
[task 2022-10-06T02:39:19.467Z] 02:39:19 INFO - c=IN IP4 0.0.0.0
[task 2022-10-06T02:39:19.467Z] 02:39:19 INFO - a=sendrecv
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - a=fmtp:109 maxplaybackrate=48000;stereo=1;useinbandfec=0
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - a=msid:stream_id
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - a=rtpmap:109 opus/48000/2
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - a=rtpmap:9 G722/8000/1
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - a=ssrc:3357916488 cname:
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - Answer SDP:
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - v=0
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - o= 0 0 IN IP4
[task 2022-10-06T02:39:19.468Z] 02:39:19 INFO - s=-
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - t=0 0
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - a=msid-semantic:WMS *
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - m=audio 0 UDP/TLS/RTP/SAVPF 109 9
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - c=IN IP4 0.0.0.0
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - a=sendrecv
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - a=fmtp:109 maxplaybackrate=16000;stereo=1;useinbandfec=0
[task 2022-10-06T02:39:19.469Z] 02:39:19 INFO - a=msid:stream_id
[task 2022-10-06T02:39:19.470Z] 02:39:19 INFO - a=rtpmap:109 opus/48000/2
[task 2022-10-06T02:39:19.470Z] 02:39:19 INFO - a=rtpmap:9 G722/8000/1
[task 2022-10-06T02:39:19.470Z] 02:39:19 INFO - a=ssrc:2975945076 cname:
[task 2022-10-06T02:39:19.470Z] 02:39:19 WARNING - TEST-UNEXPECTED-FAIL | JsepTrackTest.NonDefaultOpusParameters | test completed (time: 7ms)
[task 2022-10-06T02:39:19.471Z] 02:39:19 INFO - TEST-START | JsepTrackTest.RtcpFbWithPayloadTypeAsymmetry
[task 2022-10-06T02:39:19.471Z] 02:39:19 INFO - TEST-PASS | JsepTrackTest.RtcpFbWithPayloadTypeAsymmetry | test completed (time: 3ms)
[task 2022-10-06T02:39:19.471Z] 02:39:19 INFO - TEST-START | JsepTrackTest.AudioSdpFmtpLine
[task 2022-10-06T02:39:19.471Z] 02:39:19 INFO - TEST-PASS | JsepTrackTest.AudioSdpFmtpLine | test completed (time: 0ms)
[task 2022-10-06T02:39:19.471Z] 02:39:19 INFO - TEST-START | JsepTrackTest.NonDefaultAudioSdpFmtpLine
[task 2022-10-06T02:39:19.472Z] 02:39:19 WARNING - TEST-UNEXPECTED-FAIL | JsepTrackTest.NonDefaultAudioSdpFmtpLine | Expected equality of these values:
[task 2022-10-06T02:39:19.472Z] 02:39:19 INFO - "maxplaybackrate=32000;stereo=0;useinbandfec=0"
[task 2022-10-06T02:39:19.472Z] 02:39:19 INFO - codec->mSdpFmtpLine.valueOr("nothing")
[task 2022-10-06T02:39:19.472Z] 02:39:19 INFO - Which is: "maxplaybackrate=32000;stereo=1;useinbandfec=0" @ /builds/worker/checkouts/gecko/media/webrtc/signaling/gtest/jsep_track_unittest.cpp:1629
Flags: needinfo?(docfaraday)
Assignee | ||
Comment 8•2 years ago
|
||
Try looks fine:
https://treeherder.mozilla.org/jobs?repo=try&revision=74c31525326de59d6fa6bad9780fe1b439b350eb
https://treeherder.mozilla.org/jobs?repo=try&revision=9a000972d4c4ab47023d78188feedd4902b90b73
https://treeherder.mozilla.org/jobs?repo=try&revision=ada0e7e21914a463c6fc367f5cbbf8e05dbc2602
Flags: needinfo?(docfaraday)
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22934dbbe084 Test-case for pref. r=jib https://hg.mozilla.org/integration/autoland/rev/0405ef8d7fa8 Add media.peerconnection.sdp.disable_stereo_fmtp r=jib
Comment 10•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22934dbbe084
https://hg.mozilla.org/mozilla-central/rev/0405ef8d7fa8
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox107:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•