1793801 - "mach wpt --product chrome" fails to download the chromedriver binary for Apple M1 (arm64)

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:107.0) Gecko/20100101 Firefox/107.0 ID:20221003212025

Running mach wpt --product chrome currently fails in downloading the chromedriver binary. Maybe that happens because I'm running on an Apple M1?

 0:14.23 INFO Downloading chromedriver
 0:14.26 WARNING Failed to find versionName
Error running mach:

    ['wpt', '--product', 'chrome_android', 'testing/web-platform/tests/webdriver/tests/perform_actions/key_shortcuts.py']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file wpt| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'NoneType' object has no attribute 'split'

  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 533, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 521, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 196, in kwargs_wptrun
    kwargs = run.setup_wptrunner(venv, **kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 819, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 190, in setup
    self.setup_kwargs(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 462, in setup_kwargs
    super().setup_kwargs(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 443, in setup_kwargs
    webdriver_binary = self.browser.install_webdriver(
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 1092, in install_webdriver
    return chrome.install_webdriver_by_version(self.version(browser_binary), dest)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 704, in install_webdriver_by_version
    url = self._get_webdriver_url(version, revision)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 918, in _get_webdriver_url
    version = self._remove_version_suffix(version)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 622, in _remove_version_suffix
    return version.split(' ')[0]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As it looks like the file name has been changed between 106.0.5249.61 and 106.0.5249.21 for M1:

old: https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip
new: https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac_arm64.zip

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It seems to be a simple code change to get this working again.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1793801 - [web-platform] Fix download url for chromedriver for MacOS aarch64

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b5f8cbc5459
[web-platform] Fix download url for chromedriver for MacOS aarch64 r=jgraham

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36291 for changes under testing/web-platform/tests

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8b5f8cbc5459

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot