1793803 - Cookie banner on zeit.de can't be handled via click rule

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Emma Zühlcke [:emz]]

Tested on https://www.zeit.de/politik/ausland/2022-10/ukraine-ueberblick-gebietsgewinne-nawalny-regierungskritiker?utm_referrer=https%3A%2F%2Fnews.google.com%2F

The problem seems to be that the visibility check for the cookie banner button returns false here initially: https://searchfox.org/mozilla-central/rev/4e695325c5cfc6a37f271b98672f9c03252b1f6f/toolkit/components/cookiebanners/CookieBannerChild.jsm#233
and we don't get a MutationObserver callback when the visibility changes.

Here is the rule I've used to test this:

{
    "click": {
      "optIn": ".sp_choice_type_11",
      "presence": ".sp_choice_type_11"
    },
    "domain": "*",
    "cookies": {},
    "id": "4e6b1f68-9977-43bb-bc71-be310f99001d"
  }

Comment 1

[Neha Kochar [:neha]]

Paul will find more info.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1793803 - Add skipPresenceVisibilityCheck nsIClickRule option. r=timhuang!

This allows us to disable the visibility check for certain rules - edge cases
where the cookie banner is hidden initially and the MutationObserver in
CookieBannerChild does not pick up on visibility changes.
This can happen because we are in an iframe and the frame itself changes in
visibility.

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1793803 - Add a test with an invisible cookie banner. r=timhuang!

Depends on D160649

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1ba6aae6af
Add skipPresenceVisibilityCheck nsIClickRule option. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/8324b03edbae
Add a test with an invisible cookie banner. r=timhuang

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5c1ba6aae6af
https://hg.mozilla.org/mozilla-central/rev/8324b03edbae