Closed Bug 1793810 Opened 2 years ago Closed 2 years ago

[wdspec] Modifier key for tests running on Android is incorrectly set to the host platform

Categories

(Testing :: geckodriver, defect, P1)

defect
Points:
1

Tracking

(firefox107 fixed)

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m5], [wptsync upstream])

Attachments

(1 file)

Some of our wdspec tests on Android are currently failing because we inappropriately set the modifier key based on the host system but not where the tests are actually run:

https://searchfox.org/mozilla-central/rev/4e695325c5cfc6a37f271b98672f9c03252b1f6f/testing/web-platform/tests/webdriver/tests/perform_actions/support/keys.py#907-910

As such META is used instead of CONTROL.

We can move this code to a fixture and set the modifier based on the capabilities["platform"] value. Only mac should set the META key.

Blocks: webdriver:m5
Points: --- → 1
Priority: -- → P1
Whiteboard: [webdriver:m5]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96ccf79a8a17
[wdspec] Fix modifier key for actions tests when run on Android. r=webdriver-reviewers,jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36323 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m5] → [webdriver:m5], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: