Closed Bug 1793825 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36294 - [anchor-position] Change |NGLogicalAnchorQuery::Set| to check the list

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36294 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36294
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[anchor-position] Change |NGLogicalAnchorQuery::Set| to check the list

|NGLogicalAnchorQuery| is a linked list to keep multiple
anchors of the same name since r1039118 crrev.com/c/3851201,
because validities change as it is propagated, and queries
resolve to the first valid anchor in the tree order.

This patch changes |NGLogicalAnchorQuery::Set| to find the
|LayoutObject| by traversing the linked list, instead of
checking only the head one. The test hits a DCHECK without
this fix.

This was discussed in a CL review discussion[1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3851201/comment/0d5895d2_6792b110/

Bug: 1309178
Change-Id: I4e0746c1cc6b64d3fb10683d5aa5f819e2f590e1

Reviewed-on: https://chromium-review.googlesource.com/3854585
WPT-Export-Revision: 49a9a35ba08a671a78fe5268174ab9e68f77c4b6

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c5a6b3bc6df [wpt PR 36294] - [anchor-position] Change |NGLogicalAnchorQuery::Set| to check the list, a=testonly https://hg.mozilla.org/integration/autoland/rev/6b79a050c5a1 [wpt PR 36294] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9c5a6b3bc6df
https://hg.mozilla.org/mozilla-central/rev/6b79a050c5a1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.