1793859 - Update eslint config from upstream

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, task)

Description

[Rob Lemley [:rjl]]

End goal is to get mach commlint -l eslint to actually do the right thing.

However, there's some new items in m-c's .eslintrc.js that should be brought into c-c's version.

Specifically, there's:

• configuration for .mjs files
• an "import" plugin to support linting of ES2015+ (ES6+) import/export syntax
• a couple of minor file-matching patterns to update

It would also be nice if *.xhtml files could be linted.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1793859 - Update mach commlint to handle eslint better. r=#thunderbird-reviewers

mach commlint -l eslint was never set up properly. EsLint is kind of thick
when it comes to how it finds and loads its configuration files. The approach
that seems to work the best is to chdir into $topsrcdir/comm and run eslint
from there. This is now automatically handled by mach commlint, making it
easier to run from a subdirectory deep in the source.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1793859 - Update ESLint config with upstream ESMify changes. r=#thunderbird-reviewers

Include "eslint-plugin-import" and copy some rules from upstream. This plugin
lints ES6+ import/export statements.

Depends on D158724

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1793859 - Run eslint --fix on tree after updating .eslintrc.r=freaktechnik,#thunderbird-reviewers

Depends on D158725

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2b929e56f66
Update mach commlint to handle eslint better. r=freaktechnik,#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/26e987487a0f
Update ESLint config with upstream ESMify changes. r=freaktechnik,#thunderbird-reviewers
https://hg.mozilla.org/comm-central/rev/0835a02a9bbf
Run eslint --fix on tree after updating .eslintrc.r=freaktechnik,#thunderbird-reviewers