Closed Bug 1793887 Opened 2 years ago Closed 1 year ago

Codepen demo is slower with gpu-canvas compared to non-gpu-canvas

Categories

(Core :: Graphics: Canvas2D, defect)

defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox108 --- verified
firefox109 --- verified

People

(Reporter: mayankleoboy1, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Enable gpu-canvas
Go to https://codepen.io/Mertl/pen/GRdGNJL
Move your mouse inside the demo pane

ER: The demo changes fast in response to the mouse movement
AR: The demo lags quite a bit

Non-GPU Canvas: https://share.firefox.dev/3SZXhFL
GPU canvas: https://share.firefox.dev/3SWYOfG

Attached file about:support
Blocks: gpu-canvas

The gpu-canvas profile is all in the GPU process, looks like texImage uploads, hitting traffic and waiting for previous?
@lsalzman will know more maybe.
Sounds like a case where we just want to bail to software, maybe?

Severity: -- → S4
Flags: needinfo?(lsalzman)

If we have stroked paths whose bounds cover a lot of screen area, that can lead
to a lot of empty area in the interior that bloats the path cache textures up
with unused pixels that still need to be uploaded. Try to avoid this by not
trying to accelerate paths with the path cache that take up a large amount
of screen area.

Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
See Also: → 1777842
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77d1e4dcbe67
Limit the size of stroked path uploads. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch

Profile with latest nightly : https://share.firefox.dev/3TIOHfk
This is much better now. Thanks!

Flags: needinfo?(lsalzman)
QA Whiteboard: [qa-108b-p2]

I was able to reproduce the issue on Mac 10.13 using FF build 108.0a1(20221017213658), image from description moves slow on this version.
Verified as fixed on Win10/Mac10.13/Ubuntu 20.04 using FF build 108.0(20221205155917) and 109.0a1(20221206164509).

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-108b-p2]
See Also: → 1834079
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: