1793948 - Output mozlint warnings on autoland without failing tasks

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Bastien Abadie [:bastien]]

In order for code-review bot to ingest regularly known issues on the whole codebase, the mozlint tasks on autoland should output all warnings in their JSON artifacts, without failing the task.

A special mode should allow listing all warnings, but maintaining an exit code to 0 (when no errors are found).

Comment 1

[Valentin Rigal]

Attachment: Bug 1793948 - Softly report mozlint warnings on autoland. r=bastien,marco

Comment 2

[Bastien Abadie [:bastien]]

As discussed today, we should also run that on try: to test it, but also to get consistent output across both our ingestion source

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e97c337e8eec
Softly report mozlint warnings on autoland. r=bastien,linter-reviewers,sylvestre,ahal

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e97c337e8eec

Comment 5

[Valentin Rigal]

Attachment: Bug 1793948 - Correctly set warnings argument for mozlint parser in try/autoland. r=bastien,marco

Comment 6

[Valentin Rigal]

I pushed a new patch, as I wrongly named mozlint's warning argument (which also defaults to None when unset).

I tested with the environment variable and it works correctly now. I tested with that command : GECKO_HEAD_REPOSITORY=https://hg.mozilla.org/mozilla-centra ./mach lint -l flake8 python/mozlint/test. If the --warning or --warning=soft argument is passed, the parameter is not overridden.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b664a6468754
Correctly set warnings argument for mozlint parser in try/autoland. r=bastien,marco DONTBUILD

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b664a6468754

Comment 9

[Valentin Rigal]

Attachment: Bug 1793948 - Set warnings argument for mozlint parser in try, autoland and mozilla-central repositories. r=bastien,marco

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb848a2970c
Set warnings argument for mozlint parser in try, autoland and mozilla-central repositories. r=marco DONTBUILD

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0bb848a2970c

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38886d9e927b
Backed out changeset 0bb848a2970c for many unexpected warnings prevent spotting of errors. CLOSED TREE

Comment 14

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/38886d9e927b

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41613f6c5ce6
Set warnings argument for mozlint parser in try, autoland and mozilla-central repositories. r=marco

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/41613f6c5ce6