1793961 - Code generation for accessor decorators

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Dan Minor [:dminor]]

Code generation for decorators is likely to be complicated, so we'll split it into multiple bugs. This bug covers code generation for accessor decorators.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Don't attach decorators to synthesized getter and setter for accessors; r=arai

Previously, we were associating the decorators with the new getter and setter that
were created for the accessor, but for code generation purposes, we want them to be
associated the underlying accessor storage.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Fix applying decorators to static methods; r=arai

The existing code had a bug where the static decorators were being used to
initialize static fields as though they were instance fields. This fixes that
bug and adds the code necessary to run the static decorators to add static
initializers.

Depends on D182080

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Add tests for static private field decorators; r=arai

Depends on D182081

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Fix bug with private static accessors; r=arai

We should only create an initializer if the private accessor is not static.

Depends on D182082

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Implement code generation for accessor decorators; r=arai

Depends on D182083

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1793961 - Add DecoratorReturn to CheckIsObjectKind enum; r=arai

We need an IsObject test for the decorators implementation. We already
support this in the interpreter and in the jits, so adding the opcode
is straightforward.

Depends on D182083

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/246c79c06ccc
Don't attach decorators to synthesized getter and setter for accessors; r=arai
https://hg.mozilla.org/integration/autoland/rev/090f6bd36035
Fix applying decorators to static methods; r=arai
https://hg.mozilla.org/integration/autoland/rev/cef773277d52
Add tests for static private field decorators; r=arai
https://hg.mozilla.org/integration/autoland/rev/c275cb67393a
Fix bug with private static accessors; r=arai
https://hg.mozilla.org/integration/autoland/rev/787edb38b936
Add DecoratorReturn to CheckIsObjectKind enum; r=arai
https://hg.mozilla.org/integration/autoland/rev/947a9303000e
Implement code generation for accessor decorators; r=arai

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/246c79c06ccc
https://hg.mozilla.org/mozilla-central/rev/090f6bd36035
https://hg.mozilla.org/mozilla-central/rev/cef773277d52
https://hg.mozilla.org/mozilla-central/rev/c275cb67393a
https://hg.mozilla.org/mozilla-central/rev/787edb38b936
https://hg.mozilla.org/mozilla-central/rev/947a9303000e