179400 - URI fragment present in HTTP Referer

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[u44081]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003

URI fragments are present in HTTP Referer headers sent by Mozilla 1.0.1, though
RFC 2616, section 14.36 explicitly forbids it.


Reproducible: Always

Steps to Reproduce:
Surf to http://some.where/quux#frag, click a link, watch the headers sent by
Mozilla.
Actual Results:  
You'll see the Referer header sent as:
Referer: http://some.where/quux#frag


Expected Results:  
The Referer header should be sent without the fragment:
Referer: http://some.where/quux

Comment 1

[Darin Fisher]

yup, we're not stripping the URL fragment :(

Comment 2

[Chris Nalls]

Marking topembed+

Comment 3

[Darin Fisher]

RFC 2616 section 14.36 uses this language: "The URI MUST NOT include a fragment."

patch in hand...

Comment 4

[Darin Fisher]

Attachment: v1 patch

fixes the bug and does some long overdue cleanup of SetReferrer.

Comment 5

[Darin Fisher]

Attachment: v1 patch (-u10w for your reviewing pleasure)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 106768 [details] [diff] [review]
v1 patch (-u10w for your reviewing pleasure)

sr=bzbarsky, but do we perhaps want to save mReferrer _after_ we have set the
userpass and ref to empty?

Comment 7

[Darin Fisher]

bz: yeah, thanks for the suggestion.  i'll make that change.

Comment 8

[Darin Fisher]

fixed-on-trunk

Comment 9

[Jo Hermans]

*** Bug 144094 has been marked as a duplicate of this bug. ***

Comment 10

[Tom Everingham]

verified - trunk builds 11/20/02 win NT4, mac osX, linux rh6

before fix -
Referer:
http://slip/projects/dogbert/test/web/protocols/http/wa_http_index.html#navigationcase2

after -
Referer: http://slip/projects/dogbert/test/web/protocols/http/wa_http_index.html