1794007 - [wpt-sync] Sync PR 36318 - Merge <use> instance association and removal of disallowed elements

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36318 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36318
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Merge <use> instance association and removal of disallowed elements

If we remove an element because it's disallowed during \<use> shadow tree
construction, we won't clear the corresponding element reference that we
set up just before. This can cause the DCHECK in CorrespondingElement() to trigger, because the element will have a corresponding element, but not be part of a shadow root.

Merge the AssociateCorrespondingElements() and
RemoveDisallowedElementsFromSubtree() actions into a single subtree walk
that performs both of the actions at the same time. This is marginally
more complex and prevents a disallowed element from being associated
with its corresponding element.

Fixed: 1371700
Change-Id: I21c963d898716b1ddf1486baf07b383c74a24dc9
Reviewed-on: https://chromium-review.googlesource.com/3936288
WPT-Export-Revision: 7814527de10bb2adcb10f0dca2b7df784351560c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b7de20531c2471cfef36637d4a99d7488a3c7f1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7451b6f17aed
[wpt PR 36318] - Merge <use> instance association and removal of disallowed elements, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7451b6f17aed