re-enable private browsing shortcut creation in the firefox installer
Categories
(Firefox :: Installer, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [fidedi-pbm])
Attachments
(2 files)
https://bugzilla.mozilla.org/show_bug.cgi?id=1792546 has made a strong case for doing this. We'll need to improve the accuracy of shortcut creation to prevent the problems that caused us to disable it in the first place, but that's very achievable.
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
The current shortcut detection was good enough for a long while -- it was mainly used for Telemetry purposes, and installer created shortcuts were almost always created anyways -- so both the rate of mismatches and the consequences of them were fairly low. This changed when we implemented Private taskbar pinning, most notably because when we're creating Private Browsing shortcuts in the installer (which we ought to do to work around various Windows bugs), we end up with 2 strings for the shortcut names (one for the installer, one for the browser).
The other thing that has changed since this was originally implemented is that all of those code has moved off of the main thread -- so it is less perf-sensitive than it was before.
With these two things in mind, making our shortcut detection much more accurate seems like the right thing to do. There's still rare cases (noted in the original comments) where it could be wrong -- but with this change we no longer rely on the file name, which can very easily be wrong for a number of reasons.
This also includes a fix for a bug I introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1789974 that caused pinning not to work if a shortcut needed to be created at pinning time (unlikely except in zip builds, but still needs to be fixed).
|
|
Assignee | |
Comment 2•2 years ago
|
||
This is the same as the original patch, except for the added localization notes around the necessarily duplicated strings.
Depends on D158799
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/653cc203e9f5 improve shortcut detection of existing shortcuts in windows shell service r=bytesized https://hg.mozilla.org/integration/autoland/rev/7569f064540d create a private browsing shortcut at install time r=bytesized,fluent-reviewers,flod
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/653cc203e9f5
https://hg.mozilla.org/mozilla-central/rev/7569f064540d
Description
•